Closed Bug 950739 Opened 6 years ago Closed 6 years ago

In the App Manager, adding a break point scroll the page up

Categories

(DevTools :: WebIDE, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → paul
See Also: → 940296
This only happens when the toolbox is *inside* the app manager (in a custom host).
Attached patch v1Splinter Review
We called scrollIntoView to make sure the toolbox button was visible in the app manager. But scrollIntoView also scrolls the inner documents, like the toolbox, which messes with everything.

scrollIntoView in the app manager tabs was handy, but it's really not that useful.

And this bug blocks many people (gaia dev using the debugger).
Attachment #8348211 - Flags: review?(rcampbell)
Comment on attachment 8348211 [details] [diff] [review]
v1

Review of attachment 8348211 [details] [diff] [review]:
-----------------------------------------------------------------

alrighty then.
Attachment #8348211 - Flags: review?(rcampbell) → review+
I just want to add that hunting this bug was epic and hard. I failed to figure out what was wrong, but optimizer, blindly, figured out the whole story. I was impressed.
Keywords: checkin-needed
Duplicate of this bug: 940296
https://hg.mozilla.org/mozilla-central/rev/1627332b2e7f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
(In reply to Paul Rouget [:paul] from comment #4)
> I just want to add that hunting this bug was epic and hard. I failed to
> figure out what was wrong, but optimizer, blindly, figured out the whole
> story. I was impressed.

I am putting this on my card : "Paul is impressed" :)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.