950749 - [helper plugin] Limited by current `scriptTimeout` value

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Mike Pennisi [:jugglinmike]]

The `marionette-helper`'s `wait` method was designed to facilitate debugging tests, but it is currently limited by the client's `scriptTimeout` value. If a developer uses this method, then they expect the asynchronous script to require the specified number of milliseconds (possibly implicitly because the use of an asynchronous script is an implementation detail).

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: Pull request on GitHub.com

Hey Gareth: mind reviewing this for me?

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8348149 [details] [review]
Pull request on GitHub.com

Left a nit on GH, but LGTM otherwise. Thanks!

Comment 3

[Mike Pennisi [:jugglinmike]]

(In reply to Gareth Aye [:gaye] from comment #2)
> Comment on attachment 8348149 [details] [review]
> Pull request on GitHub.com
> 
> Left a nit on GH, but LGTM otherwise. Thanks!

Ah, I'd never used `Client#scope` before--much cleaner! Your suggestion uncovered a bug in the Marionette JS client itself; I've opened bug 950973 to track its resolution.

Comment 4

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/marionette-helper/commit/e3d8e64d28ed7835e4263cab95676ddc825639e4

Gareth: This went a little stale since I was waiting on bug 950973 and its dependencies. I've incorporated your feedback, released a new version of the Marionette JS Client, and (finally) merged the patch. Thanks for you help!