Closed
Bug 950749
Opened 11 years ago
Closed 11 years ago
[helper plugin] Limited by current `scriptTimeout` value
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jugglinmike, Assigned: jugglinmike)
References
Details
Attachments
(1 file)
The `marionette-helper`'s `wait` method was designed to facilitate debugging tests, but it is currently limited by the client's `scriptTimeout` value. If a developer uses this method, then they expect the asynchronous script to require the specified number of milliseconds (possibly implicitly because the use of an asynchronous script is an implementation detail).
Assignee | ||
Comment 1•11 years ago
|
||
Hey Gareth: mind reviewing this for me?
Attachment #8348149 -
Flags: review?(gaye)
Comment 2•11 years ago
|
||
Comment on attachment 8348149 [details] [review]
Pull request on GitHub.com
Left a nit on GH, but LGTM otherwise. Thanks!
Attachment #8348149 -
Flags: review?(gaye) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Gareth Aye [:gaye] from comment #2)
> Comment on attachment 8348149 [details] [review]
> Pull request on GitHub.com
>
> Left a nit on GH, but LGTM otherwise. Thanks!
Ah, I'd never used `Client#scope` before--much cleaner! Your suggestion uncovered a bug in the Marionette JS client itself; I've opened bug 950973 to track its resolution.
Depends on: 950973
Assignee | ||
Comment 4•11 years ago
|
||
master: https://github.com/mozilla-b2g/marionette-helper/commit/e3d8e64d28ed7835e4263cab95676ddc825639e4
Gareth: This went a little stale since I was waiting on bug 950973 and its dependencies. I've incorporated your feedback, released a new version of the Marionette JS Client, and (finally) merged the patch. Thanks for you help!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•