Closed
Bug 950793
Opened 11 years ago
Closed 11 years ago
Loop over all codecs in can_play_type_webm.js
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: j, Assigned: j)
References
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8348201 -
Flags: review?(giles)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8348201 [details] [diff] [review]
0001-Bug-950793-Loop-over-all-supported-codecs-in-test.patch
Review of attachment 8348201 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
::: content/media/test/can_play_type_webm.js
@@ +17,5 @@
> + video.forEach(function(vcodec) {
> + check("video/webm; codecs=" + vcodec, "probably");
> + audio.forEach(function(acodec) {
> + check("video/webm; codecs=\"" + vcodec + ", " + acodec + "\"", "probably");
> + check("video/webm; codecs=\"" + acodec + ", " + vcodec + "\"", "probably");
For full paranoia you could check with and without the quotation marks and space. That's covered by the ogg test though so perhaps not worth the extra code.
Attachment #8348201 -
Flags: review?(giles) → review+
|
|
||
Comment 3•11 years ago
|
||
Assignee: nobody → j
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•