950795 - [Messages] Reduce the use of ids in the "you received a message" notice

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

+++ This bug was initially created as a clone of Bug #950074 +++

STR:
* have 2 devices A and B
* from device A, open the thread for the phone number of device B. This thread must have a scroll bar
* scroll it up
* with the phone B, send a sms to phone A

=> a notice containing the text "New message from <phone number>" with a "read it" button is displayed.


In this bug I want to simplify the markup to reduce the use of ids.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: WIP patch

This needs JS changes to make it work properly.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: current master style

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: style after this patch

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Hey Steve, here is, at least, the patch to reduce the use of ids in this area.

See also the github PR at https://github.com/mozilla-b2g/gaia/pull/15596

I also slightly changed the style to match the spec.

Comment 5

[Julien Wajsberg [:julienw]]

See the spec at attachment 810514 [details], with Ayman's change at bug 905208 comment 53.

Unfortunately I don't find a spec with actual numbers but I'm quite sure I found one back when I did this style...

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8363562 [details] [diff] [review]
patch v1

Review of attachment 8363562 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

Comment 7

[Julien Wajsberg [:julienw]]

master: b5996ecc624ea68421050f592577ad2e673655a6

thanks!