Closed Bug 950836 Opened 11 years ago Closed 11 years ago

webmaker-i18n shouldn't throw an error if an invalid configuration is passed

Categories

(Webmaker Graveyard :: Localization, defect)

Product:
Webmaker Graveyard
Component:
Localization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jon, Assigned: alicoding)

Details

Attachments

(1 file)

https://github.com/mozilla/node-webmaker-i18n/pull/29
53 bytes, text/x-github-pull-request
jon
: review+
Details | Review 
I accidently enabled a wrong locale on production and it took down the server. Rather than throwing an error, could the module just ignore that language?
Comment on attachment 8348512 [details] [review]
https://github.com/mozilla/node-webmaker-i18n/pull/29

r+ with one nit, you don't need to remove the unsupported lang from options.supported_languages I think
Attachment #8348512 - Flags: review?(jon) → review+
merged https://github.com/alicoding/node-webmaker-i18n/commit/ccdf7e833d6e58bf6ce7ec18178ac3500dca986f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: