950873 - Switch Social.jsm to use asynchronous Promise.jsm

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

We need to switch usage of the potentially-synchronous sdk/core/promise.js to the always async Promise.jsm. This is an intermediate step so we can seamlessly replace Promise.jsm usage with DOM Promises were necessary

https://groups.google.com/forum/#!topic/mozilla.dev.platform/1hbhYytitUI

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 950873

Tiny patch, looks like nothing was depending on it being synchronous -- Good!
https://tbpl.mozilla.org/?tree=Try&rev=decab3fda0f4

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8349132 [details] [diff] [review]
950873

go for it!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/bdceb89107db

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdceb89107db

Comment 5

[u279076]

Is there anything QA should be on the look out for? Jordan, please advise.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

This shouldn't have any noticible changes -- it only ensures that if a promise is resolved immediately, it does it on the next tick. If anything changes from this, then that's not a good sign. All the tests are passing, but if something comes up, let me know!

Comment 7

[u279076]

Thanks Jordan. I spoke with Shane about this yesterday and he suggested doing some smoketesting of SocialMarks before and after this landed. Basically looking for SocialMarks behaviour to be unchanged between the two. I'm flagging this for verification along those lines.

Comment 8

[Andrei Vaida [:avaida]]

I performed smoke testing on SocialMarks [1] according to Comment 7 and encountered three potential issues. Jordan, please take a look at the below, but note that the mentioned behavior occurs both before and after this fix landed.

(a) The widget panel displayed on mark button press shows cutoff bullet points in case of increased panel size.
** Context: mark a website using the flag button > press again the flag button > press the "change panel size" button until several bullet points are shown at the bottom of the panel (e.g. "Item ___ # 0").
** Reproducible on the latest Beta (Build ID: 20140331125246), with: Mac OS X 10.9.1 [2], Windows 7 64-bit [3].

(b) The widget panel displayed on "Open" button hover becomes blank after enabling full screen.
**Context: hold mouse over the "Open" button > press the F11 key to enable full screen.
** Issue reproducible for the mark button as well, using the same steps as specified above.
** Reproducible intermittently on the latest Beta (Build ID: 20140331125246), with: Windows 7 64-bit [3].

(c) Pressing the "Settings" button always brings up a share location doorhanger.
** Reproducible on the latest Beta (Build ID: 20140331125246) , with: Mac OS X 10.9.1 [2], Windows 7 64-bit [3].

At this point, I suspect that (b) might be something related to my machine and (c) might depict the expected behavior, please let me know what are your thoughts on any of the above. I also wasn't sure if the fix affects Mac OS X only, or other platforms as well.


1. http://mixedpuppy.github.io/socialapi-directory/en-US/
2. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
3. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Comment 9

[Shane Caraveo (:mixedpuppy)]

None of these would be issues related to the change in this bug.

a) post another bug with STR and pictures if you can reproduce, I cannot.
b) I'm unable to reproduce, post another bug if you can with more details.
c) a silly bug in the demo/test provider, not a bug in firefox.

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)
> None of these would be issues related to the change in this bug.
> 
> a) post another bug with STR and pictures if you can reproduce, I cannot.
> b) I'm unable to reproduce, post another bug if you can with more details.
> c) a silly bug in the demo/test provider, not a bug in firefox.

Thanks for the quick reply, I will file new bugs for the above issues. Marking this verified.