Closed
Bug 950876
Opened 11 years ago
Closed 10 years ago
Support Contacts Unit Test Doesn't
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: qdot, Assigned: qdot)
Details
Attachments
(1 file, 1 obsolete file)
The Support Contacts Unit Test was copypasted from the wallpaper customizer test. It writes the contacts key/value block to the wallpaper, and we just check to make sure the settings lock was fired. Yes. Really. https://github.com/mozilla-b2g/gaia/blob/711854acd1bbc861d46c1a4a9a303d91a44a7026/apps/communications/ftu/test/unit/support_contacts_customizer_test.js
|
Assignee | |
Comment 1•11 years ago
|
||
This isn't a 100% fix (we're still just testing to see if the lock was fired, not if things were set correctly), but it's improved over what it was before.
Attachment #8348435 -
Flags: review?(aus)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8348435 -
Attachment is patch: false
Attachment #8348435 -
Attachment mime type: text/plain → application/x-github-pullrequest
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8348435 -
Attachment mime type: application/x-github-pullrequest → text/x-github-pullrequest
|
|
Assignee | |
Comment 2•11 years ago
|
||
Using the right URL helps.
Attachment #8348435 -
Attachment is obsolete: true
Attachment #8348435 -
Flags: review?(aus)
Attachment #8348438 -
Flags: review?(aus)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8348438 [details] [review] Patch 1 (v2) - Make Support Contacts test use correct customizer It's already a really good start!
Attachment #8348438 -
Flags: review?(aus) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/14731 https://github.com/qdot/gaia/commit/69614933cd3b88ca85681b83bc4e330363390f8e Merged
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•