950956 - Install XPI countdown display untrue, than actually doubled

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[YF (Yang)]

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131209204824

Steps to reproduce:

Set security.dialog_enable_delay to 10000 ms, try install a XPI.


Actual results:

The 'Install ()' time starts from 21 seconds, and to reduce with double speed. The actual delay time is correct.


Expected results:

Correct display for 'installButtonDisabledLabel'.

It seems should be "Math.round(delay_in_milliseconds / 500);".
See also: https://bitbucket.org/cat_in_136/configuration-mania/issue/133/securitydialog_enable_delay-not-equal

Comment 1

[Dave Townsend [:mossop]]

Well the dialog doesn't actually say it is counting down in seconds, it is just a generic countdown. I think we made it count faster than seconds to feel a little faster. Given that the default delay is 1 second it probably wouldn't make sense to use seconds here, it'd just say 1 then ready to install, not a countdown at all.

Comment 2

[YF (Yang)]

(In reply to Dave Townsend (:Mossop) from comment #1)
> Well the dialog doesn't actually say it is counting down in seconds, it is
> just a generic countdown. I think we made it count faster than seconds to
> feel a little faster. Given that the default delay is 1 second it probably
> wouldn't make sense to use seconds here, it'd just say 1 then ready to
> install, not a countdown at all.

Yes, maybe it is not important now, the Nightly is 1000 ms now. But I still think it be anti-common sense, because people usually think this count is second, but actually is a half-second. It is intentionally made ​​it an illusion?