950957 - mach completion on relative paths busted

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Martin Thomson [:mt:]]

Attachment: Completion based on COMP_WORDS[0]

The default completion for mach doesn't need to try to work out what the name of the command is.  It currently gets confused if you don't have mach on the path and the command is not run from $srcdir.

The fix is easy, run "${COMP_WORDS[0]}".  The only risk (which already existed) is that this rule fires on something that is not mach, but bash thinks it is.

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 8348391 [details] [diff] [review]
Completion based on COMP_WORDS[0]

Review of attachment 8348391 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. Thanks for the patch!

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8348391 [details] [diff] [review]
Completion based on COMP_WORDS[0]

Can I leave the checkin to you then?

Comment 3

[Gregory Szorc [:gps]]

I just set checkin-needed and let the tree sheriffs land when they think it's a good time. Typically less than 24h.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27cf4fe3975b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/27cf4fe3975b