Closed Bug 950959 Opened 11 years ago Closed 10 years ago

Rename ScheduledCycleCollectNow and nsCycleCollector_scheduledCollect

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Also maybe ScheduledCC.  Olli pointed out that the current names are weird, and should probably talk about incremental collection.  Maybe something like RunCycleCollectorSlice would be better.

One odd corner is that PrepareForGarbageCollection runs Collect() with ScheduledCC.  I think the reason for this is that we only want to finish the current CC, not do a new one.  I should document that, because it wasn't obvious and I had to re-read the code to figure it out.
Attachment #8355025 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/75f3963a307e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: