Closed
Bug 950959
Opened 11 years ago
Closed 11 years ago
Rename ScheduledCycleCollectNow and nsCycleCollector_scheduledCollect
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
9.05 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Also maybe ScheduledCC. Olli pointed out that the current names are weird, and should probably talk about incremental collection. Maybe something like RunCycleCollectorSlice would be better.
One odd corner is that PrepareForGarbageCollection runs Collect() with ScheduledCC. I think the reason for this is that we only want to finish the current CC, not do a new one. I should document that, because it wasn't obvious and I had to re-read the code to figure it out.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8355025 -
Flags: review?(bugs)
Updated•11 years ago
|
Attachment #8355025 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Thanks for the reviews!
https://hg.mozilla.org/integration/mozilla-inbound/rev/75f3963a307e
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•