950968 - Notes+ app shows large image without resizing to fit screen

Status: VERIFIED FIXED

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect)

Description

[Yan Or]

Images wider than the device screen will be clipped and hard to see.
Should resize image to fit screen width.

Comment 1

[Yan Or]

Attachment: Pull request

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8355993 [details] [review]
Pull request

r+ from Matias

Comment 3

[Ryan VanderMeulen [:RyanVM]]

phase2: https://github.com/mozilla-b2g/notes/commit/eedcb3cbfc34def6f486a79e1547cd54674e395a

Comment 4

[Peter Bylenga [:PBylenga]]

I'm not sure if it's intended behavior but I'm seeing all images as attachments instead of being embedded as before.  Because they are now attachments they are no longer displayed within the body of a note.

App built using:
https://github.com/mozilla-b2g/notes/tree/phase2

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a43cb4b322d3
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Platform Version: 28.0a2
Firmware Version: 20131115

Comment 5

[Yan Or]

That is not the intended behavior.  Can you provide step by step on how to reproduce this?
Also, is this reproducible on the simulator?

Comment 6

[Peter Bylenga [:PBylenga]]

Using steps found in bug 956950 to build the app I am able to verify that large images no longer clip the screen and are re sized after a cropping step to fit the view.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a43cb4b322d3
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Platform Version: 28.0a2
Firmware Version: 20131115