951019 - Port bug 915735 to mail/installer/package-manifest.in and suite/installer/package-manifest.in

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Makoto Kato [:m_kato]]

When using ICU build, some files will be added on Windows. We should update package-manifest.in for bug 915735.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: icu

Comment 2

[Mark Banner (:standard8)]

Makoto, did you mean to request review?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Mark Banner (:standard8) from comment #2)
> Makoto, did you mean to request review?

This isn't tested yet.  After testing, set review flag.

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 8350508 [details] [diff] [review]
icu

So to test this I basically would have to build with --enable-shared-js and then create an installer?
Actually on Windows JS shared lib should be default. I wonder how to test this as I don't see any icudt*.dll files in my bin/ folder. Do I need other special build options for ICU?

Comment 5

[Frank Wein [:mcsmurf]]

I guess the answer is to build with "--with-intl-api" as so far this is only the default for Firefox.

Comment 6

[Frank Wein [:mcsmurf]]

I filed Bug 958523 on not being able to use "--with-intl-api" with SeaMonkey or Thunderbird (it's a configure bug IMHO).

Comment 7

[Frank Wein [:mcsmurf]]

Comment on attachment 8350508 [details] [diff] [review]
icu

Patch works fine on Windows, I trust you to get the file names right for *unix and OS X :). Note I used the patch from Bug 958523 to test this. I guess in the end libicu will get enabled for all platforms, including Android and B2G (from what I saw in the mentioned bug #)?

Comment 8

[Makoto Kato [:m_kato]]

(In reply to Frank Wein [:mcsmurf] from comment #7)
> Comment on attachment 8350508 [details] [diff] [review]
> icu
> 
> Patch works fine on Windows, I trust you to get the file names right for
> *unix and OS X :). Note I used the patch from Bug 958523 to test this. I
> guess in the end libicu will get enabled for all platforms, including
> Android and B2G (from what I saw in the mentioned bug #)?

bug 864843 for Android and B2G.  This has packaging fix, too.  Many people are waiting to use ICU for IndexedDB, BIDI and etc.  So ICU will turn on all platform.

Comment 9

[Magnus Melin [:mkmelin]]

m_kato: so this is ready to land, no?

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Magnus Melin from comment #9)
> m_kato: so this is ready to land, no?

Ah, I forget this bug.  I land it soon.

Comment 11

[Makoto Kato [:m_kato]]

now, tree closed. after open, i will land this.

Comment 12

[Wayne Mery (:wsmwk)]

(In reply to Makoto Kato (:m_kato) from comment #11)
> now, tree closed. after open, i will land this.

gentle ping

Comment 13

[Makoto Kato [:m_kato]]

remote: Tree Seamonkey comm-central is CLOSED! ....

Comment 14

[Magnus Melin [:mkmelin]]

I think that's been closed a long time, you may want to just ask approval over irc and land it... while the tb tree is still open ;)

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to Makoto Kato (:m_kato) from comment #13)
> remote: Tree Seamonkey comm-central is CLOSED! ....

NeilAway> wsm: packaging fixes can usually land with a heads-up from ewong or Callek

Comment 16

[Frank Wein [:mcsmurf]]

It's ok to land with CLOSED TREE on comm-central/SeaMonkey for now.

Comment 17

[Mark Banner (:standard8)]

I just pushed this to make sure it landed before the merges:

https://hg.mozilla.org/comm-central/rev/fd35deed885d

Comment 18

[Makoto Kato [:m_kato]]

thanks, Mark!