951030 - [Airplane mode] airplane mode cannot be turned off after restart

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Paul Yang [:pyang] (away)]

Reproducible on dsds [fugu] machine.

Gaia      cbd29217ea37209449774b0c31cbfbdd2da6ee68
Gecko     0711d9529ced971c85244c4be3504d01edf5161d
BuildID   20131211154453
Version   28.0a2
ro.build.version.incremental=13

Reproduce steps:
1. Turn on airplane mode
2. Before it actually turned on, restart the device.

EXPECT:
- Airplane mode is turned on, and can be turned off.

ACTUAL:
- User cannot turn off airplane mode, which disables data connection.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Hi Paul,

Need your help to reproduce the bug. I have tried it several times but didn't trigger the problem.
My Steps:
0. fugu with 2 sim cards
1. turn on airplane mode from (a) utility tray or (b) settings
2. after I tap the icon, reboot the phone by "adb reboot" immediately
3. after the power on, turn off airplane mode. It takes some time, but will be OK eventually.

Comment 2

[Paul Yang [:pyang] (away)]

After doing some experiments,
Enable data call may be a key factor of this bug.
Please help to enable data connection before reproducing.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: radio state rollback

Rollback radio state if setRadioEnabled fails.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8351084 [details] [diff] [review]
radio state rollback

Review of attachment 8351084 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thank you.

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +2873,5 @@
>      }
>  
>      let callback = (function(response) {
> +      if (response.errorMsg) {
> +        // Request fail. Rollback to the original radiostate.

nit: s/fail/fails/

::: dom/system/gonk/ril_worker.js
@@ +5237,5 @@
>    if (DEBUG) debug("Operator: " + operatorData);
>    this._processOperator(operatorData);
>  };
>  RIL[REQUEST_RADIO_POWER] = function REQUEST_RADIO_POWER(length, options) {
> +  options.errorMsg = RIL_ERROR_TO_GECKO_ERROR[options.rilRequestError];

Please place this line after the clause of |if (options.rilMessageType == null)| because we don't need it if options.rilMessageType isn't null.

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Radio state rollback. r=hsinyi

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=cd9aaccd0885

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e0d22cbe1e83

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e0d22cbe1e83

Comment 9

[Enpei]

Verified on fugu

Gaia      ee25b0e45649d2955f340ce4f71ad55712dd0fab
Gecko     913cf2b92845441c9578787362ddad6f2ac15df6
BuildID   20140121095108
Version   28.0a2