951072 - [Clock] Text alignment issue in alarm list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Helen Huang [:HHuang]]

Text for alarm repeat is shifted.

Comment 1

[Gnaneswar]

(In reply to Helen Huang from comment #0)
> Text for alarm repeat is shifted.

Could you elaborate the issue?
Also If possible attaching the screenshot would be helpful.

Comment 2

[Helen Huang [:HHuang]]

Attachment: Clock_Alarm_alignment.jpg

The text of repeating days should be aligned to alarm time.
I screenshot the current alarm page and take a note on it, please find the attached. Thank you!

Comment 3

[Gnaneswar]

Attachment: Github PR to fix the misalignment of text in repeat alarm

Thanks for the spec.

Please let me know your comments on attached patch

Comment 4

[Helen Huang [:HHuang]]

Comment on attachment 8358364 [details] [review]
Github PR to fix the misalignment of text in repeat alarm

Thanks for implementing!

Comment 5

[Gnaneswar]

Would like to know by when this patch will get merged.

Comment 6

[Gnaneswar]

Travis build failures seems unrelated to my change

Comment 7

[Gnaneswar]

Thanks mcav for merging this patch!

Comment 8

[Marcus Cavanaugh [:mcav]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/97bc550b88ac234246b22113da63680b0cac8126

Thanks for the patch! I'm still catching up somewhat on old bugs and such; feel free to needinfo me if you see any others that need attention.

Comment 9

[Edward Chen[:edchen]]

[Environment]
Gaia      8a2352d5b7be27ec4b1ea18c680ebcd0b6d34348
Gecko     https://hg.mozilla.org/mozilla-central/rev/cb9f34f73ebe
BuildID   20140520040203
Version   32.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

[Resutt]
PASS