951082 - Figure out what nsReferencedElement::Reset should do if nsContentUtils::ConvertStringFromEncoding fails

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henri Sivonen (:hsivonen)]

If nsContentUtils::ConvertStringFromEncoding fails, it means that fallible allocation failed. We should probably stick to something other than trying conversion from UTF-8 without handling UTF-8 errors as the fallback case.

I.e. don't do 
  nsresult rv = nsContentUtils::ConvertStringFromEncoding(charset,
                                                          refPart,
                                                          ref);
  if (NS_FAILED(rv)) {
    CopyUTF8toUTF16(refPart, ref);
  }

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8752170 [details] [diff] [review]
patch

Review of attachment 8752170 [details] [diff] [review]:
-----------------------------------------------------------------

Commit message nit:

> Bug 951082 - Make nsReferencedElement::Reset fail if nsContentUtils::ConvertStringFromEncoding fails. r=dholbert

Maybe "fail if" --> "fail if its call to", to make the relationship a bit clearer.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c85bfdc5442

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8c85bfdc5442