951123 - [Settings] Call waiting switch on "Confirm Call waiting" screen is broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Théo Chevalier]

Attachment: Screeshot - before patch

Since 1.3, the toggle switch on the "Confirm call waiting preference" is broken.

PR incoming.

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14751

I hope that's the kind of patch that looks too easy... and is actually too easy :)

Comment 2

[Théo Chevalier]

Attachment: Screenshot - after patch

Comment 3

[Théo Chevalier]

Reason for blocking 1.3: the setting label is unreadable, + broken UI.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Hey eeejay, could this issue be a regression caused by bug 914892? Thanks.

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #4)
> Hey eeejay, could this issue be a regression caused by bug 914892? Thanks.

Looks like it is, yes.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: broken UI.

Comment 7

[Fabien Cazenave [:kaze]]

Thanks Théo for this good catch. Merged on master:
https://github.com/mozilla-b2g/gaia/commit/b12152456063166e3539e59a3d476b7bde8cffe4

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted b12152456063166e3539e59a3d476b7bde8cffe4 to:
v1.3: 864823f62f62d260bb7db50e7cc2618590842e56