Closed Bug 951130 Opened 11 years ago Closed 10 years ago

Contacts Export view is visually incorrect

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S1 (14feb)
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: jmcf, Assigned: arnau)

Details

Attachments

(2 files)

device-2014-01-07-190303.png
37.49 KB, image/png
Details
patch in github
275 bytes, text/html
jmcf
: review+
praghunath
: approval-gaia-v1.3+
Details 
Export contacts view is visually incorrect. Check boxes are too much on the left
blocking-b2g: --- → 1.3?
can you please provide screenshots?  thanks
Flags: needinfo?(jmcf)
the checkboxes are too much on the left hand side
Flags: needinfo?(jmcf)
Definitely, something has changed, cannot remember those checks buttons so close to the left side.
triage: not blocking release. please ask for approval for 1.3 uplift thanks
blocking-b2g: 1.3? → -
Comment on attachment 8360432 [details]
patch in github

thanks Arnau
Attachment #8360432 - Flags: review?(jmcf) → review+
https://github.com/mozilla-b2g/gaia/commit/696fb3056c070e60cb9b71ddbf8c65a6b3e1639c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8360432 [details]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: high, incorrect visuals
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): no risk
[String changes made]:
Attachment #8360432 - Flags: approval-gaia-v1.3?(francisco.jordano)
Attachment #8360432 - Flags: approval-gaia-v1.3?(francisco.jordano)
Attachment #8360432 - Flags: approval-gaia-v1.3?
Recovering approval-gaia-v1.3? flag but remaining it as unassigned for release mgmt review. Thanks!
Preeti, will you be approving this one? Thanks
Flags: needinfo?(praghunath)
Yes Joe I will be reviewing this.
Flags: needinfo?(praghunath)
Comment on attachment 8360432 [details]
patch in github

Getting the left check boxes corrected and hence will be taking this is in 1.3
Attachment #8360432 - Flags: approval-gaia-v1.3? → approval-gaia-v1.3+
v1.3: 414e81215e789543ec4527b192575826c22bf686
status-b2g-v1.3: affected → fixed
status-b2g-v1.4: --- → fixed
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: