Convert Gaia UI Tests to new Notification API

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
P1
normal
RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: gerard, Assigned: gentlefolk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
tests/python/gaia-ui-tests/gaiatest/tests/functional/lockscreen/test_lockscreen_notification.py:        self.marionette.execute_script('navigator.mozNotification.createNotification("%s", "%s").show();'

tests/python/gaia-ui-tests/gaiatest/tests/functional/lockscreen/test_lockscreen_wake_with_notification.py:        self.marionette.execute_script('navigator.mozNotification.createNotification("%s", "%s").show();'

tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_system_notification_bar.py:        self.marionette.execute_script('navigator.mozNotification.createNotification("%s", "%s").show();'

Comment 1

4 years ago
I didn't notice this one come in, I'll put it in at P2.

Alexandre, what is the syntax for the new Notification? Is there a wiki doc for it?
Flags: needinfo?(lissyx+mozillians)
Priority: -- → P2
(Reporter)

Comment 2

4 years ago
Sure, you have the doc at https://developer.mozilla.org/en-US/docs/Web/API/notification#Methods

And one example of migration in bug https://bugzilla.mozilla.org/show_bug.cgi?id=948341
Flags: needinfo?(lissyx+mozillians)

Comment 3

4 years ago
Updating to P1 because this has been sitting around for far too long.
Priority: P2 → P1

Updated

4 years ago
Assignee: lissyx+mozillians → cemacken
(Assignee)

Comment 4

4 years ago
Created attachment 8371206 [details] [review]
Updated UI tests to new notifcation API
Attachment #8371206 - Flags: review?(zcampbell)

Comment 5

4 years ago
Comment on attachment 8371206 [details] [review]
Updated UI tests to new notifcation API

Pushing this to AndreiH..can you check these 3 tests on device too then r?/merge! thanks
Attachment #8371206 - Flags: review?(zcampbell) → review?(andrei.hutusoru)

Comment 6

4 years ago
Comment on attachment 8371206 [details] [review]
Updated UI tests to new notifcation API

Travis looks good and tests are running great on the device
Attachment #8371206 - Flags: review?(andrei.hutusoru) → review+

Comment 7

4 years ago
Merged!

https://github.com/mozilla-b2g/gaia/commit/055ae60b5753af1d463f7d3c1cfb9f32862d55ab
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.