951159 - Convert Gaia UI Tests to new Notification API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[:gerard-majax]

tests/python/gaia-ui-tests/gaiatest/tests/functional/lockscreen/test_lockscreen_notification.py:        self.marionette.execute_script('navigator.mozNotification.createNotification("%s", "%s").show();'

tests/python/gaia-ui-tests/gaiatest/tests/functional/lockscreen/test_lockscreen_wake_with_notification.py:        self.marionette.execute_script('navigator.mozNotification.createNotification("%s", "%s").show();'

tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_system_notification_bar.py:        self.marionette.execute_script('navigator.mozNotification.createNotification("%s", "%s").show();'

Comment 1

[Zac C (:zac)]

I didn't notice this one come in, I'll put it in at P2.

Alexandre, what is the syntax for the new Notification? Is there a wiki doc for it?

Comment 2

[:gerard-majax]

Sure, you have the doc at https://developer.mozilla.org/en-US/docs/Web/API/notification#Methods

And one example of migration in bug https://bugzilla.mozilla.org/show_bug.cgi?id=948341

Comment 3

[Zac C (:zac)]

Updating to P1 because this has been sitting around for far too long.

Comment 4

[Craig MacKenzie [:gentlefolk]]

Attachment: Updated UI tests to new notifcation API

Comment 5

[Zac C (:zac)]

Comment on attachment 8371206 [details] [review]
Updated UI tests to new notifcation API

Pushing this to AndreiH..can you check these 3 tests on device too then r?/merge! thanks

Comment 6

[[:AndreiH]]

Comment on attachment 8371206 [details] [review]
Updated UI tests to new notifcation API

Travis looks good and tests are running great on the device

Comment 7

[[:AndreiH]]

Merged!

https://github.com/mozilla-b2g/gaia/commit/055ae60b5753af1d463f7d3c1cfb9f32862d55ab