Closed
Bug 951234
Opened 10 years ago
Closed 10 years ago
slaveapi shouldn't assume that a slave has a master
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
3.05 KB,
patch
|
jhopkins
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
I hit a few slaves like this while testing out bug 914764.
Attachment #8348842 -
Flags: review?(jhopkins)
Comment 1•10 years ago
|
||
Comment on attachment 8348842 [details] [diff] [review] don't assume a master exists + if not slave.master_url: + return FAILURE, "%s - No master set, can't initiate graceful shutdown." + If a build slave isn't connected to a master, it can't take any jobs, right? I'm not sure bailing out is the right thing to do.
Flags: needinfo?(bhearsum)
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to John Hopkins (:jhopkins) from comment #1) > Comment on attachment 8348842 [details] [diff] [review] > don't assume a master exists > > + if not slave.master_url: > + return FAILURE, "%s - No master set, can't initiate graceful > shutdown." > + > > If a build slave isn't connected to a master, it can't take any jobs, right? > I'm not sure bailing out is the right thing to do. If a buildslave doesn't have a master set, it's impossible to initiate a graceful shutdown. Ignoring bug 914764 for a moment, what else could we do here? I suppose we could set SUCCESS rather than FAILURE, but I can't think of anything else that could be done inside of the shutdown_buildslave action.
Flags: needinfo?(bhearsum)
Comment 3•10 years ago
|
||
Comment on attachment 8348842 [details] [diff] [review] don't assume a master exists r+ with the following FAILURE changed to SUCCESS, as discussed in IRC: + if not slave.master_url: + return FAILURE, "%s - No master set, can't initiate graceful shutdown." +
Attachment #8348842 -
Flags: review?(jhopkins) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8348842 [details] [diff] [review] don't assume a master exists Landed w/ the requested change and a version bump: http://git.mozilla.org/?p=build/slaveapi.git;a=commitdiff;h=2f762051ab1579fbb6ac2199a1ad37ca8328d755;hp=27fd33a59e1aa77b9146fda8ed3db91772abf969
Attachment #8348842 -
Flags: checked-in+
Assignee | ||
Comment 5•10 years ago
|
||
Deployed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•