Closed Bug 951235 Opened 11 years ago Closed 10 years ago

npm install called from back-ticks expression

Categories

(Firefox OS Graveyard :: Gaia, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86_64
Linux
Type:
defect

Tracking

(b2g-v1.3T fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C2/1.4 S2(17jan)
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: hub, Assigned: hub)

Details

(Keywords: perf, Whiteboard: [c=automation p=1 s= u=])

Attachments

(1 file)

Pull request
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
In both gaia-marionette and gaia-perf-marionette, npm install is called from a backtick expression....

This cause the output to be attempted to run as a command.

Note: gaia-perf-marionette just did cut & paste.
Summary: npm install calle from back-ticks expression → npm install called from back-ticks expression
Attached file Pull request — 
James, any feedback?
Assignee: nobody → hub
Status: NEW → ASSIGNED
Attachment #8348857 - Flags: feedback?(jlal)
Keywords: perf
Priority: -- → P2
Whiteboard: [c=automation p=1 s= u=]
Comment on attachment 8348857 [details] [review]
Pull request

Updated PR. It should be better now. Works better with bug 958652, albeit not mandatory.
Attachment #8348857 - Flags: feedback?(jlal) → review?(felash)
Comment on attachment 8348857 [details] [review]
Pull request

r=me

You're right, it's probably a good idea to land this after bug 958652.
Attachment #8348857 - Flags: review?(felash) → review+
Merged.

https://github.com/mozilla-b2g/gaia/commit/b02097abb423cf819a3326b98f35617a02cee3bd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: