Closed
Bug 951235
Opened 12 years ago
Closed 12 years ago
npm install called from back-ticks expression
Categories
(Firefox OS Graveyard :: Gaia, defect, P2)
Tracking
(b2g-v1.3T fixed)
RESOLVED
FIXED
1.3 C2/1.4 S2(17jan)
| Tracking | Status | |
|---|---|---|
| b2g-v1.3T | --- | fixed |
People
(Reporter: hub, Assigned: hub)
Details
(Keywords: perf, Whiteboard: [c=automation p=1 s= u=])
Attachments
(1 file)
In both gaia-marionette and gaia-perf-marionette, npm install is called from a backtick expression....
This cause the output to be attempted to run as a command.
Note: gaia-perf-marionette just did cut & paste.
|
Assignee | |
Updated•12 years ago
|
Summary: npm install calle from back-ticks expression → npm install called from back-ticks expression
|
|
Assignee | |
Comment 1•12 years ago
|
||
James, any feedback?
|
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 8348857 [details] [review]
Pull request
Updated PR. It should be better now. Works better with bug 958652, albeit not mandatory.
Attachment #8348857 -
Flags: feedback?(jlal) → review?(felash)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8348857 [details] [review]
Pull request
r=me
You're right, it's probably a good idea to land this after bug 958652.
Attachment #8348857 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
|
|
Assignee | |
Comment 5•11 years ago
|
||
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•