Disable "click on selected text to copy"

VERIFIED FIXED in Firefox 29

Status

()

Firefox for Android
Text Selection
VERIFIED FIXED
4 years ago
a year ago

People

(Reporter: wesj, Assigned: Veeti Paananen)

Tracking

Trunk
Firefox 29
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=margaret][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
The "click on text to copy it" feature isn't in standard Android. Now that we have an actionbar, its easier visually to see how to copy. We should disable the feature.
(Reporter)

Updated

4 years ago
Blocks: 768667

Updated

4 years ago
Whiteboard: [mentor=margaret][lang=js]

Updated

4 years ago
Component: General → Text Selection
(Assignee)

Comment 1

4 years ago
Created attachment 8350956 [details] [diff] [review]
951274.patch

Updated

4 years ago
Attachment #8350956 - Flags: review?(margaret.leibovic)

Comment 2

4 years ago
Comment on attachment 8350956 [details] [diff] [review]
951274.patch

Review of attachment 8350956 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/SelectionHandler.js
@@ -79,5 @@
> -          let data = JSON.parse(aData);
> -          if (this._pointInSelection(data.x, data.y))
> -            this.copySelection();
> -          else
> -            this._closeSelection();

I was worried we might still need this code to get rid of the selection if the user taps outside of it, but I was able to verify that the focus change takes care of that for us, so we don't need this.
Attachment #8350956 - Flags: review?(margaret.leibovic) → review+

Comment 3

4 years ago
Thanks so much for the patch!
Assignee: nobody → veeti.paananen
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/b2ec8cc7299d
Keywords: checkin-needed
Whiteboard: [mentor=margaret][lang=js] → [mentor=margaret][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b2ec8cc7299d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=margaret][lang=js][fixed-in-fx-team] → [mentor=margaret][lang=js]
Target Milestone: --- → Firefox 29

Updated

4 years ago
Status: RESOLVED → VERIFIED

Updated

4 years ago
Depends on: 970054
Blocks: 1086933
No longer blocks: 1086933
You need to log in before you can comment on or make changes to this bug.