951274 - Disable "click on selected text to copy"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Wesley Johnston (:wesj)]

The "click on text to copy it" feature isn't in standard Android. Now that we have an actionbar, its easier visually to see how to copy. We should disable the feature.

Comment 1

[Veeti Paananen]

Attachment: 951274.patch

Comment 2

[:Margaret Leibovic]

Comment on attachment 8350956 [details] [diff] [review]
951274.patch

Review of attachment 8350956 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/SelectionHandler.js
@@ -79,5 @@
> -          let data = JSON.parse(aData);
> -          if (this._pointInSelection(data.x, data.y))
> -            this.copySelection();
> -          else
> -            this._closeSelection();

I was worried we might still need this code to get rid of the selection if the user taps outside of it, but I was able to verify that the focus change takes care of that for us, so we don't need this.

Comment 3

[:Margaret Leibovic]

Thanks so much for the patch!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b2ec8cc7299d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2ec8cc7299d