951275 - [Keyboard] Enter should just enter and not preventDefault if an autocorrect can be made

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

Lets say you have a textarea that on keycode 13 submits.

Now you type something the dictionary doesnt know and wants to autocorrect, and you type ENTER.

The word gets replaced, the form is not submitted, and a newline is inserted in the textarea.

First, we should respect the event and let it fire. Then if the keydown/keyup did not get canceled, we can do a replacement.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Test case

1. Set locale to English
2. Type a word that we know 'Jan', press enter. Event gets canceled.
3. Type a mistaken word 'Tes', press enter. Gets replaced by 'Yes' and inserts a newline.
4. Additional: pressing backspace keeps you on the newline but fixes the word...

I think this is actually in gaia.

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Ok, clearing the mentor flag, as this has both gecko & gaia implications, so not a good starter bug :p

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

The patch is included in 952078. https://github.com/mozilla-b2g/gaia/pull/14851/files?w=1#diff-8702d22395c6a86f3d58c20db7020ce8R519