951331 - [Messages][Drafts] MMS indicator missing for MMS drafts in existing (non-threadless) threads

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Evelyn Eastmond [:evhan55]]

STR:

1. Open a thread with sent messages (i.e. not threadless)
2. Draft an MMS message
3. Click back. Choose 'Save as Draft'

Expected:
- 'MMS' indicator in thread entry in thread list

Actual:
- No 'MMS' indicator in thread entry in thread list

Comment 1

[Evelyn Eastmond [:evhan55]]

The STR above is on top of rwaldron/v1.3drafts + rwaldron/947211

Comment 2

[Julien Wajsberg [:julienw]]

Related and probably the same bug: the MMS indicator is showing if the last (real) message in the thread is a MMS but there is a SMS draft.

Comment 3

[Evelyn Eastmond [:evhan55]]

(In reply to Julien Wajsberg [:julienw] (PTO until January 6th) from comment #2)
> Related and probably the same bug: the MMS indicator is showing if the last
> (real) message in the thread is a MMS but there is a SMS draft.

Thank you, my fix addresses this case.

Comment 4

[Evelyn Eastmond [:evhan55]]

(In reply to Evelyn Eastmond [:evhan55] from comment #3)
> (In reply to Julien Wajsberg [:julienw] (PTO until January 6th) from comment
> #2)
> > Related and probably the same bug: the MMS indicator is showing if the last
> > (real) message in the thread is a MMS but there is a SMS draft.
> 
> Thank you, my fix addresses this case.

Hmmm, but not when the app launches.

Comment 5

[Evelyn Eastmond [:evhan55]]

(In reply to Evelyn Eastmond [:evhan55] from comment #4)
> Hmmm, but not when the app launches.

Ok figured out how to fix thread indicator upon launch, too.

Comment 6

[Evelyn Eastmond [:evhan55]]

Changed the name of the bug to handle two different cases:

**lastMessageType indicator not accurate**

STR:

1. Open a thread with sent messages (i.e. not threadless)
2. Draft an MMS message
3. Click back. Choose 'Save as Draft'

Expected:
- 'MMS' indicator in thread entry in thread list

Actual:
- No 'MMS' indicator in thread entry in thread list

**Draft indicator not accurate**

STR:
1. From thread list, open an existing thread that is not threadless (properly registered as a thread)
2. Start a draft in that thread
3. Click back. Choose 'save as draft'
4. Notice the draft status/icon for that thread
5. Force quit Messages app via task manager
6. Open Messages app

Expected:
See the draft status/icon for that recently edited thread

Actual:
No draft status/icon for the recently edited thread, it shows up as if it didn't have a draft

Comment 7

[Evelyn Eastmond [:evhan55]]

Nevermind on the bug name change, going back to just solving this bug:

STR:

1. Open a thread with sent messages (i.e. not threadless)
2. Draft an MMS message
3. Click back. Choose 'Save as Draft'

Expected:
- 'MMS' indicator in thread entry in thread list

Actual:
- No 'MMS' indicator in thread entry in thread list

Comment 8

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15376

I'm not sure how to write this unit test, any guidance appreciated!

Comment 9

[Evelyn Eastmond [:evhan55]]

Comment on attachment 8360600 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15376

Submitting for review after getting help:

- `thread_list_ui.js
    - set the lastMessageType to the draft's message type before applying a style to the DOM element
- Tests
    - `thread_list_ui_test.js`
        - Refactored the 'Correctly displayed content' test suite
        - Added test to check that `li.dataset.lastMessageType` was properly set if draft is of type 'mms'
        - Manually tested on device

Comment 10

[Rick Waldron [:rwaldron]]

Comment on attachment 8360600 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15376

So simple, i love it. r=me

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8360600 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15376

yeah, this looks good, thanks !

Comment 12

[Evelyn Eastmond [:evhan55]]

Landed and closed: https://github.com/mozilla-b2g/gaia/commit/6fe4937157bdf4a3872d1fdd1a178a63bbea538f