Closed Bug 951352 Opened 6 years ago Closed 6 years ago

Disallow XPIDL_MODULE if no XPIDL_SOURCES are defined

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file, 1 obsolete file)

I just reviewed a patch where someone had an XPIDL_MODULE without any corresponding XPIDL_SOURCES in a moz.build variable. We should just reject that build configuration because it makes no sense.
Depends on: 939044
Once upon a time XPIDL_MODULE and MODULE were kind of the same and
MODULE got mass-converted into XPIDL_MODULE with the removal of MODULE
in bug 939044. Unfortunately, we forgot to add a check for XPIDL_MODULE
being defined if XPIDL_SOURCES isn't (a build config that makes no sense
and only results in cargo culting).

This patch corrects that oversight.

https://tbpl.mozilla.org/?tree=Try&rev=8bd00380e8a3
Attachment #8348980 - Flags: review?(mh+mozilla)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Found a few more stragglers. I hooked up reader.walk_topsrcdir() to
verify I got them all this time.

https://tbpl.mozilla.org/?tree=Try&rev=dc6747173931
Attachment #8349059 - Flags: review?(mh+mozilla)
Attachment #8348980 - Attachment is obsolete: true
Attachment #8348980 - Flags: review?(mh+mozilla)
Comment on attachment 8349059 [details] [diff] [review]
Disallow XPIDL_MODULE if XPIDL_SOURCES isn't defined

Review of attachment 8349059 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wappush/interfaces/moz.build
@@ -3,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> -XPIDL_SOURCES += [
> -]

Might be worth adding a check for empty lists, too. Followup?
Attachment #8349059 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4fcb5a4ebae

I'll file a bug for the empty list bit.
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/e4fcb5a4ebae
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
comm-central build error:
XPIDL_MODULE cannot be defined unless there are XPIDL_SOURCES: db/mork/public

Pushed comm-central bustage fix.
http://hg.mozilla.org/comm-central/rev/2242984765ce
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.