951355 - [traceback] AttributeError: 'Http404' object has no attribute 'has_header' - django.contrib.sessions.middleware in process_response

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

22.6k tracebacks!

http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/471/

django.contrib.sessions.middleware in process_response
AttributeError: 'Http404' object has no attribute 'has_header'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 188, in get_response
    response = middleware_method(request, response)
  File "amo/middleware.py", line 115, in process_response
    .process_response(request, response))
  File "django/contrib/sessions/middleware.py", line 26, in process_response
    patch_vary_headers(response, ('Cookie',))
  File "django/utils/cache.py", line 140, in patch_vary_headers
    if response.has_header('Vary'):

Comment 1

[Vincent Agnano [:vinyll]]

That bug seems to have a lot in common with https://bugzilla.mozilla.org/show_bug.cgi?id=873550
It is common when returning an Http404 instead of raising it. I'd suspect https://github.com/mozilla/zamboni/blob/master/apps/files/decorators.py#L26 but not sure how or where the `allowed` decorator is used.

Can't reproduce in local and I have no access to Sentry. I submit a PR about the lines above and we'll see…

Comment 2

[Vincent Agnano [:vinyll]]

This COULD be fixed with https://github.com/mozilla/zamboni/commit/22a3a771d069ce5045b862dfafcf59fd6f4f240a.

I won't mark it fixed until someone who has access to the Sentry checks the logs.

Comment 3

[Wil Clouser [:clouserw]]

It's still happening in production, but your commit landed 4 days ago so it wouldn't have been live yet.  We'll need to verify this after next Tuesday at noon.  No reason to keep this bug open though.