Closed Bug 951401 Opened 11 years ago Closed 11 years ago

middleware setup should throw an error when unknown language was set

Categories

(Webmaker Graveyard :: Localization, defect)

Product:
Webmaker Graveyard
Component:
Localization
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alicoding, Assigned: alicoding)

Details

Attachments

(1 file)

https://github.com/mozilla/node-webmaker-i18n/pull/35
53 bytes, text/x-github-pull-request
reyre
: review+
Details | Review 
If we set an unknown language or language that is not in the locale directory the middleware setup should fail on that part.
Comment on attachment 8350333 [details] [review]
https://github.com/mozilla/node-webmaker-i18n/pull/35

Left some comments on the PR.

r=me with tests passing.
Attachment #8350333 - Flags: review?(rick.eyre) → review+
https://github.com/alicoding/node-webmaker-i18n/commit/684bb066d566ddbc02afb841be780e8187814a9b 

Thanks @Rick
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: