Closed Bug 951403 Opened 11 years ago Closed 2 years ago

Intermittent browser_885052_customize_mode_observers_disabed.js | Uncaught exception - Condition timed out: (function () /* use strict */ !fullscreenButton.checked) followed by many more

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: RyanVM, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on OSX][leave open][Australis:P-] p=13)

Attachments

(1 file)

Patch
2.62 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=32110401&tree=Fx-Team

Rev5 MacOSX Mountain Lion 10.8 fx-team opt test mochitest-browser-chrome on 2013-12-17 13:34:27 PST for push c2912eda9a01
slave: talos-mtnlion-r5-009

13:41:07     INFO -  TEST-START | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js
13:41:07     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Entering test
13:41:07     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Fullscreen button should not be checked when not in fullscreen.
13:41:08     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Fullscreen button should be checked when in fullscreen.
13:41:08     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Observer should be moved to wrapper
13:41:08     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Observer should be removed from button
13:41:08     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Fullscreen button should no longer be checked during customization mode
13:41:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Uncaught exception - Condition timed out: (function () /* use strict */ !fullscreenButton.checked)
13:41:14     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | Leaving test
13:41:14     INFO -  TEST-INFO | MEMORY STAT vsize after test: 4116434944
13:41:14     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 575102976
13:41:14     INFO -  TEST-INFO | MEMORY STAT heapAllocated after test: 133025960
13:41:14     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js | finished in 6474ms

etc etc etc...
This might get fixed by the patch in bug 933926.
Blocks: 885052
Attached patch Patch — — Splinter Review 
I'd like to wait for the try results to come back for the extra runs, but the code review can happen concurrently.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8350250 - Flags: review?(mconley)
Comment on attachment 8350250 [details] [diff] [review]
Patch

Review of attachment 8350250 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, I'm good with this.

::: browser/components/customizableui/test/browser.ini
@@ +10,5 @@
>  [browser_877447_skip_missing_ids.js]
>  [browser_878452_drag_to_panel.js]
>  [browser_880164_customization_context_menus.js]
>  [browser_880382_drag_wide_widgets_in_panel.js]
> +[browser_885052_customize_mode_observers_disabled.js]

Oh yes, thanks for that. disabed was really starting to bug me.
Attachment #8350250 - Flags: review?(mconley) → review+
Do we know what's going on here? This is making my bugmail sad. :-(
Flags: needinfo?(jaws)
I pushed an updated patch to tryserver for this two days ago (https://tbpl.mozilla.org/?tree=Try&rev=ce168f71b61e) but it still showed the same failure.

I haven't figured out why this is failing.
Flags: needinfo?(jaws)
So if I --run-until-failure, I can reproduce this locally. It seems like the problem is to do with the fact that the fullScreen status is set and, um, we don't actually go back into fullscreen. Everything pretends that we do, and we enter and exit customize mode and everything, but at that point the window is visually still in restored mode. Only when calling BrowserFullScreen a second time does the window actually go fullscreen. I... don't know why. See also bug 946768.
See also very nearly every instance of isOSXMtnLion in the tree, because we skip lots of fullscreen tests on 10.8 due to flaky notifications of being fullscreen when we aren't. Adding this to the things we skip would be a Good Thing, given the frequency and the destructive nature of the failure mode.
Disabled on OSX.
https://hg.mozilla.org/integration/fx-team/rev/f94b4d3fb9cf
Whiteboard: [test disabled on OSX][leave open]
Whiteboard: [test disabled on OSX][leave open] → [test disabled on OSX][leave open][Australis:P-]
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Flags: firefox-backlog+
Whiteboard: [test disabled on OSX][leave open][Australis:P-] → [test disabled on OSX][leave open][Australis:P-] p=13
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3

This passes now. Re-enabled in bug 1776496.
https://hg.mozilla.org/mozilla-central/rev/0a73bd558e8c

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: