playback of imap msg copy operations doesn't coalesce copies with same destination

VERIFIED FIXED

Status

SeaMonkey
MailNews: Backend
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
When you move multiple imap messages from one folder to another, we should play
back the copy operations with one copy command to the server instead of a
seperate operation for each message. To recreate this bug, setup imap protocol
logging, go offline, select several imap messages, copy them to another imap
folder, and then go back online. Then, look at the protocol log. W/o the fix,
you should see separate copy commands sent to the server for each message. With
the fix, it should be one copy operation.
(Assignee)

Comment 1

17 years ago
cc'ing Seth and Navin for code review. Fix coming up. The fix is obvious - we
were trying to check if the next imap offline operation to playback had the same
destination as the current op, but we weren't putting the next imap offline
destination in the right variable. This bug existed in 4.x as well, and was
faithfully ported to 6.x
Status: NEW → ASSIGNED
(Assignee)

Comment 2

17 years ago
Created attachment 45683 [details] [diff] [review]
proposed fix

Comment 3

17 years ago
r=naving
(Assignee)

Comment 5

17 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
Gary, here is how you setup the IMAP log for Win98 platform:

Create "c:\tmp" for IMAP log file reside if there is no such directory 
Insert the following line into your autoexec.bat file: 
Set NSPR_LOG_MODULES=IMAP:5 
Set NSPR_LOG_FILE=c:\tmp\[filename] (ex:map5io.txt)
(filename can be defined by you) 
Reboot your system.

Comment 7

17 years ago
Commercial builds
2001082703 - win nt 4.0
2001082708 - linux 2.2, mac 9.0.4

Following David's steps and steps from Karen/Laurel
http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap
Note that have to go back online after doing the copying in order
for the log to note that you did do a copy.

Verified, on all platforms, the protocol logs now does only 1 copy 
command when copying multiple messages from one folder to another. 
Tried copying both downloaded and non-downloaded messages while offline 
and it worked.

The log now displays this when copying multiple messages while offline:
  243[5ab9280]: linzilla.mcom.com:S-INBOX:SendData: 7 uid copy 10,26 "test"

Before it displayed this (tested with 6.1 rtm build)
  205[4af8e60]: linzilla.mcom.com:S-INBOX:SendData: 7 uid copy 10 "test"
  205[4af8e60]: linzilla.mcom.com:S-INBOX:CreateNewLineFromSocket: 7 OK 
                [COPYUID 999019239 10 3] Completed
  205[4af8e60]: linzilla.mcom.com:S-INBOX:SendData: 8 uid copy 73 "test"

Marking as verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.