Closed Bug 951463 Opened 6 years ago Closed 6 years ago

Rename ClampRect to be more meaningful


(Core :: Panning and Zooming, defect)

Gonk (Firefox OS)
Not set



blocking-b2g 1.3+
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed


(Reporter: ajones, Assigned: ajones)



(5 files, 1 obsolete file)

Clean up and simplify CalculatePendingDisplayPort to make it easier to understand.
Component: Graphics: Layers → Panning and Zooming
port size.  However the position has already been calculated correctly a
couple of lines above.
Attached patch My alternative WIP (obsolete) — Splinter Review
This is what I just finished writing. Haven't even compiled it yet. Note that as part of this I'm shrinking the displayport size when skating and increasing it while stationary. We found on Fennec (and I'm seeing the same thing on B2G) that a larger displayport takes much longer to paint and when moving fast the extra time it takes to paint invariable means more misses.
Slightly tweaked to not do stupid things.
Attachment #8350329 - Attachment is obsolete: true
Comment on attachment 8350471 [details] [diff] [review]
Rename ClampRect to ForceInside;

Review of attachment 8350471 [details] [diff] [review]:

r=me with the comment update.

::: gfx/2d/BaseRect.h
@@ +442,5 @@
>    /**
>     * Clamp aRect to this rectangle. This returns aRect after it is forced
>     * inside the bounds of this rectangle. It will attempt to retain the size
>     * but will shrink the dimensions that don't fit.

This comment needs to be updated to reflect the change in direction.
Attachment #8350471 - Flags: review?(botond) → review+
Ok, so I'm going to hijack this bug for the renaming of ClampRect, and then do all the CalculatePendingDisplayPort cleanup stuff in bug 907179.
Summary: APZC clean up for CalculatePendingDisplayPort → Rename ClampRect to be more meaningful
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Uplifted to Aurora as a bustage fix because bug 907179 (a 1.3 blocker) depends on it. Retroactively requesting blocking status to close the loop.
blocking-b2g: --- → 1.3?
blocking-b2g: 1.3? → 1.3+
You need to log in before you can comment on or make changes to this bug.