Rename ClampRect to be more meaningful

RESOLVED FIXED in Firefox 28, Firefox OS v1.3

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kentuckyfriedtakahe, Assigned: kentuckyfriedtakahe)

Tracking

unspecified
mozilla29
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed)

Details

Attachments

(5 attachments, 1 obsolete attachment)

Clean up and simplify CalculatePendingDisplayPort to make it easier to understand.
Component: Graphics: Layers → Panning and Zooming
Created attachment 8350315 [details] [diff] [review]
Remove bogus adjustment;  looks like the adjustment is being made because of a change in the display

port size.  However the position has already been calculated correctly a
couple of lines above.
Created attachment 8350317 [details] [diff] [review]
Remove bogus default duration;  duration is defaulting to 1 second which makes no sense whatsoever. It is

safer to default to zero or simply remove the extra logic altogether.
Created attachment 8350318 [details] [diff] [review]
Simplify display port calculation logic;
Created attachment 8350329 [details] [diff] [review]
My alternative WIP

This is what I just finished writing. Haven't even compiled it yet. Note that as part of this I'm shrinking the displayport size when skating and increasing it while stationary. We found on Fennec (and I'm seeing the same thing on B2G) that a larger displayport takes much longer to paint and when moving fast the extra time it takes to paint invariable means more misses.
Created attachment 8350342 [details] [diff] [review]
My alternative WIP

Slightly tweaked to not do stupid things.
Attachment #8350329 - Attachment is obsolete: true
Created attachment 8350471 [details] [diff] [review]
Rename ClampRect to ForceInside;
Attachment #8350471 - Flags: review?(botond)
Comment on attachment 8350471 [details] [diff] [review]
Rename ClampRect to ForceInside;

Review of attachment 8350471 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment update.

::: gfx/2d/BaseRect.h
@@ +442,5 @@
>  
>    /**
>     * Clamp aRect to this rectangle. This returns aRect after it is forced
>     * inside the bounds of this rectangle. It will attempt to retain the size
>     * but will shrink the dimensions that don't fit.

This comment needs to be updated to reflect the change in direction.
Attachment #8350471 - Flags: review?(botond) → review+
Ok, so I'm going to hijack this bug for the renaming of ClampRect, and then do all the CalculatePendingDisplayPort cleanup stuff in bug 907179.
Summary: APZC clean up for CalculatePendingDisplayPort → Rename ClampRect to be more meaningful
https://hg.mozilla.org/mozilla-central/rev/031f4999c5fe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Uplifted to Aurora as a bustage fix because bug 907179 (a 1.3 blocker) depends on it. Retroactively requesting blocking status to close the loop.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2850f1dad667
blocking-b2g: --- → 1.3?
status-b2g-v1.3: --- → fixed
status-firefox27: --- → wontfix
status-firefox28: --- → fixed
status-firefox29: --- → fixed

Updated

5 years ago
blocking-b2g: 1.3? → 1.3+
You need to log in before you can comment on or make changes to this bug.