951542 - PJS: Race between interrupt check and main thread finishing

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Shu-yu Guo [:shu]]

We currently race between the main thread finishing its work and a worker
thread trying to abort due to the interrupt flag. If the main thread has
already finished its work, the worker thread will never abort.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: fix

Comment 2

[Niko Matsakis [:nmatsakis]]

Comment on attachment 8349226 [details] [diff] [review]
fix

Review of attachment 8349226 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, although it might be easier (or at least more self-contained) to add a (volatile/atomic) flag to the ForkJoinShared that gets set when executeFromMainThread() returns.

Comment 3

[Shu-yu Guo [:shu]]

(In reply to Niko Matsakis [:nmatsakis] from comment #2)
> Comment on attachment 8349226 [details] [diff] [review]
> fix
> 
> Review of attachment 8349226 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This seems fine, although it might be easier (or at least more
> self-contained) to add a (volatile/atomic) flag to the ForkJoinShared that
> gets set when executeFromMainThread() returns.

That'd be the preferred solution in the current world, but doesn't work with work stealing, thus the RAII thing.

Comment 4

[Shu-yu Guo [:shu]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1e4903ca67df

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e4903ca67df