Clean up dead code from dom/workers/RuntimeService.cpp after removal of heuristic detection from the File API

RESOLVED FIXED in mozilla29

Status

()

Core
DOM: Workers
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: hsivonen, Assigned: Ehsan)

Tracking

unspecified
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

2.26 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Remove mDetectorName and mSystemCharset from RuntimeService.cpp, since they should be dead code after bug 848842. I realized this just now thanks to an MXR search done while researching another bug. :-(
(Assignee)

Comment 1

4 years ago
Created attachment 8349827 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8349827 - Flags: review?(hsivonen)
Comment on attachment 8349827 [details] [diff] [review]
Patch (v1)

Review of attachment 8349827 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing, r=me.
Attachment #8349827 - Flags: review?(hsivonen) → review+
https://hg.mozilla.org/mozilla-central/rev/d86702f2170c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.