951571 - Remove T.61-8bit

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P5)

Description

[Henri Sivonen (:hsivonen)]

T.61-8bit is marked as internal but is not used internally:

Not used by name:
https://mxr.mozilla.org/comm-central/search?string=T.61-8bit

Not used by CID:
https://mxr.mozilla.org/comm-central/search?string=kNS_T61TOUNICODE_CID

Not used by constructor:
https://mxr.mozilla.org/comm-central/search?string=nsT61ToUnicodeConstructor

We should remove the dead code.

Comment 1

[Henri Sivonen (:hsivonen)]

Hmm. I suppose this might still get instantiated by Thunderbird, considering that UTF-7 is marked as internal, too. Let's wait for telemetry.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Backup of WIP (need to check nsUCConstructors for dead code, still)

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Remove T.61

https://tbpl.mozilla.org/?tree=Try&rev=c75684a64004

Notes:
x.509 theoretically uses T.61, but in practice our code assumes the strings in certificates are UTF-8.

LDAP uses T.61, but the LDAP code has its own T.61 conversion code.

Therefore, neither of the supposed use cases actually uses this code!

Leaving the Histograms.json entry in so that the Telemetry Dashboard still displays the probe for Thunderbird 31.

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8419978 [details] [diff] [review]
Remove T.61

Nice cleanup!

Comment 5

[Henri Sivonen (:hsivonen)]

Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bee2d76e711

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9bee2d76e711