T.61-8bit is marked as internal but is not used internally: Not used by name: https://mxr.mozilla.org/comm-central/search?string=T.61-8bit Not used by CID: https://mxr.mozilla.org/comm-central/search?string=kNS_T61TOUNICODE_CID Not used by constructor: https://mxr.mozilla.org/comm-central/search?string=nsT61ToUnicodeConstructor We should remove the dead code.
Hmm. I suppose this might still get instantiated by Thunderbird, considering that UTF-7 is marked as internal, too. Let's wait for telemetry.
Assignee: hsivonen → nobody
Status: ASSIGNED → NEW
Created attachment 8349299 [details] [diff] [review] Backup of WIP (need to check nsUCConstructors for dead code, still)
Created attachment 8419978 [details] [diff] [review] Remove T.61 https://tbpl.mozilla.org/?tree=Try&rev=c75684a64004 Notes: x.509 theoretically uses T.61, but in practice our code assumes the strings in certificates are UTF-8. LDAP uses T.61, but the LDAP code has its own T.61 conversion code. Therefore, neither of the supposed use cases actually uses this code! Leaving the Histograms.json entry in so that the Telemetry Dashboard still displays the probe for Thunderbird 31.
Assignee: nobody → hsivonen
Attachment #8349299 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8419978 - Flags: review?(VYV03354)
Comment on attachment 8419978 [details] [diff] [review] Remove T.61 Nice cleanup!
Attachment #8419978 - Flags: review?(VYV03354) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.