Closed Bug 951579 Opened 8 years ago Closed 7 years ago
Command+Shift+P enters full screen instead of opening a new Private Browsing window
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:28.0) Gecko/20100101 Firefox/28.0, build id: 20131217004003 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:27.0) Gecko/20100101 Firefox/27.0, build id: 20131216183647 Command+Shift+P keyboard shortcut enters the browser in fullscreen mode instead of opening a new private browsing window Steps to reproduce: 1. Launch Firefox using the "an" locale 2. Press Command+Shift+P Expected result: A new Private Browsing window opens Actual result: Browser enters full screen mode
In chrome://browser/locale/browser.dtd file there we have: <!ENTITY fullScreenCmd.macCommandKey "p"> <!ENTITY privateBrowsingCmd.commandkey "P">
Adding the right Daniel to the bug.
On bug 951208 comment 7 Daniel stated that the change has been landed on aurora: http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/a1689f02eb22 Since then the problem didn't appear for us. So can we close this bug?
It looks like a fix went in here with the following changesets: http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/diff/b5cb81ef48ee/browser/chrome/browser/browser.dtd http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/diff/845938c2e54f/browser/chrome/browser/browser.dtd I do not see test failures for the latest beta even, so I assume we can get this marked as fixed.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.