Closed Bug 951587 Opened 6 years ago Closed 6 years ago

Unable to compile 64-bit js shells on Windows

Categories

(Core :: JavaScript Engine, defect, blocker)

x86_64
Windows 7
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: gkw, Assigned: ehsan)

References

Details

(Keywords: regression, Whiteboard: [fuzzblocker])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #948301 +++

Build failure on Windows is still not yet fixed. Tested with a threadsafe deterministic 64-bit js shell on m-c rev 862cb6a1cc88.

Setting needinfo from glandium as he just patched bug 948301, I can get more logs if so required.
Flags: needinfo?(mh+mozilla)
Attached patch Patch (v1)Splinter Review
Please try this patch.
Attachment #8349416 - Flags: feedback?(gary)
(This doesn't have anything to do with the previous bugs.  Not everything is ICU's fault ;)
Blocks: 945042
No longer blocks: 915735
No longer depends on: 948534, 947683, 948301
Comment on attachment 8349416 [details] [diff] [review]
Patch (v1)

This works. Thanks!
Attachment #8349416 - Flags: feedback?(gary) → feedback+
Attachment #8349416 - Flags: review?(mh+mozilla)
Attachment #8349416 - Flags: review?(gps)
Comment on attachment 8349416 [details] [diff] [review]
Patch (v1)

Review of attachment 8349416 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/moz.build
@@ +430,1 @@
>          SOURCES['ctypes/CTypes.cpp'].no_pgo = True # Bug 810661

I was going to suggest that modification of SOURCES entries occur closer to where they are assigned. But you have an issue of synchronization of conditional blocks no matter where the code is. Boo.
Attachment #8349416 - Flags: review?(mh+mozilla)
Attachment #8349416 - Flags: review?(gps)
Attachment #8349416 - Flags: review+
Flags: needinfo?(mh+mozilla)
Assignee: nobody → ehsan
https://hg.mozilla.org/mozilla-central/rev/e7bb99d245e8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.