951587 - Unable to compile 64-bit js shells on Windows

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Build failure with m-c rev 862cb6a1cc88

+++ This bug was initially created as a clone of Bug #948301 +++

Build failure on Windows is still not yet fixed. Tested with a threadsafe deterministic 64-bit js shell on m-c rev 862cb6a1cc88.

Setting needinfo from glandium as he just patched bug 948301, I can get more logs if so required.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Please try this patch.

Comment 2

[(no longer active)]

(This doesn't have anything to do with the previous bugs.  Not everything is ICU's fault ;)

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 8349416 [details] [diff] [review]
Patch (v1)

This works. Thanks!

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8349416 [details] [diff] [review]
Patch (v1)

Review of attachment 8349416 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/moz.build
@@ +430,1 @@
>          SOURCES['ctypes/CTypes.cpp'].no_pgo = True # Bug 810661

I was going to suggest that modification of SOURCES entries occur closer to where they are assigned. But you have an issue of synchronization of conditional blocks no matter where the code is. Boo.

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7bb99d245e8

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7bb99d245e8