951611 - mozilla::layers::GestureEventListener gets stuck in GESTURE_WAITING_PINCH state

Status: RESOLVED DUPLICATE of bug 951321

(Core :: Panning and Zooming, defect)

Description

[dmitry.rojkov]

Attachment: Patch reseting pinch state when not multi touch

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131206152142

Steps to reproduce:

1. Go to ampparit.com
2. try to zoom in/out quikly with pinching
3. when pinching try to lift one of two fingers, this increases chances to trigger bug.


Actual results:

If you are lucky the links at the left side of the page will stop to accept taps. Reproducible quite reliably in SailfishOS browser which is based on gecko 26.0 currently.

It seems that when GestureEventListener is in GESTURE_WAITING_PINCH state and a touchmove event with only one touch point comes in GestureEventListener doesn't exit from GESTURE_WAITING_PINCH state.

Also reproducible with gecko 29.0


Expected results:

browser should always handle singe taps on links. When multi-touch event contains only one touch point it's not GESTURE_WAITING_PINCH any more as the transation GESTURE_WAITING_PINCH -> GESTURE_PINCH becomes unreachible (it's protected with the condition (mTouches.Length() > 1 && !aClearTouches)).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Thanks for the report and the patch! Actually Vivien also submitted a patch to fix this issue this morning shortly before you did. I'm going to dupe this bug over to that one since it was filed earlier.