951665 - [Dialer] Call screen when in lockscreen visual refresh 2.0

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Update incomming call to new visual design.
Specs to follow

Comment 1

[Maria Angeles Oteo (:oteo)]

A new reduced scope for v1.4 has been delivered within the 1.4 Dialer Visual Refresh meta bug 950760, please refer to it for the visual material.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

This bug will cover the following visuals:
 - attachment 8370135 [details]

Being the specs available at attachment 8370141 [details].

Comment 3

[Victoria Gerchinhoren [:vicky]]

Due to the contrast ratio issue, colors have been adjusted. Please refer to the updated mockups and specs in the metabug (https://bugzilla.mozilla.org/show_bug.cgi?id=950760)m

Please change the colors and replace icons and ask for UI review.

Thanks.

Comment 4

[Anthony Ricaud (:rik)]

We discussed with Germán how to best land this. We're gonna land the callscreen refresh in bug 951606 in coordination with the work here. This is so that the application looks fairly ok at all times. This will avoid people freaking out that we broke the lockscreen in any way.

Vicky: We will land something that is not UI perfect here. Germán will open a bug to refine the lockscreen version so that it meets the visual specs. This will be worked on during the current sprint.

Comment 5

[Anthony Ricaud (:rik)]

Also, I'm delegating the review to Doug here.

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 19782.html

Comment 7

[Victoria Gerchinhoren [:vicky]]

(In reply to Anthony Ricaud (:rik) (out until June 2nd) from comment #4)
> We discussed with Germán how to best land this. We're gonna land the
> callscreen refresh in bug 951606 in coordination with the work here. This is
> so that the application looks fairly ok at all times. This will avoid people
> freaking out that we broke the lockscreen in any way.
> 
> Vicky: We will land something that is not UI perfect here. Germán will open
> a bug to refine the lockscreen version so that it meets the visual specs.
> This will be worked on during the current sprint.

Cool. Sounds good to me.

Comment 8

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8430970 [details]
19782.html

I left a couple of final comments. Please address them and then I think we're good to go!

Comment 9

[Anthony Ricaud (:rik)]

Germán: Bug 951606 was merged without this just after. Can you do that first thing today?

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Yeah, yeah, I had to go to bed without the OK from Travis which was taking ages to get all green :-) In fact, I just relaunched the Marionette tests because of an intermittent error with the new vertical home screen. Hopefully it will get green and I'll merge the patch ;-)

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

And merging once Travis is all green ;)

Merged in master: https://github.com/mozilla-b2g/gaia/commit/31e03cbc07b0f432992a770242f75861c850f3cb

Comment 12

[Maria Angeles Oteo (:oteo)]

According to comment 4, Bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen has been created

Comment 13

[Loli (:lolimartinezcr)]

 Tested and verified (pending comment 12 in other bug created)
Hamachi
2.0
Gecko:3e5340d
Gaia:7416a20