951666 - Rename IonCode to JitCode

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Baseline also uses IonCode, so JitCode is a better name. I'd like to finally get this done before the end of the year :)

Requesting review from Nicholas for the memory reporter changes and Nicolas for the rest.

Comment 1

[Jan de Mooij [:jandem]]

Btw JitCode is still defined in IonCode.h. I think it should get its own header because IonCode.h also defines IonScript etc but this patch was big enough already.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8349413 [details] [diff] [review]
Patch

I can review the whole thing.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8349413 [details] [diff] [review]
Patch

Review of attachment 8349413 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

I assume you've done a case-insensitive grep for "ioncode"... it certainly looks like you did :)

I recommend a |try: -b do -p all -u none -t none| try push on any patch that touches this much code, even though the changes are trivial.

Comment 4

[Jan de Mooij [:jandem]]

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c5539b5b8f5

(In reply to Nicholas Nethercote [:njn] from comment #3)
> I recommend a |try: -b do -p all -u none -t none| try push on any patch that
> touches this much code, even though the changes are trivial.

Yup, looks green: https://tbpl.mozilla.org/?tree=Try&rev=58d3a8b0c377

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c5539b5b8f5