Rename IonCode to JitCode

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Posted patch PatchSplinter Review
Baseline also uses IonCode, so JitCode is a better name. I'd like to finally get this done before the end of the year :)

Requesting review from Nicholas for the memory reporter changes and Nicolas for the rest.
Attachment #8349413 - Flags: review?(nicolas.b.pierron)
Attachment #8349413 - Flags: review?(n.nethercote)
Assignee

Comment 1

6 years ago
Btw JitCode is still defined in IonCode.h. I think it should get its own header because IonCode.h also defines IonScript etc but this patch was big enough already.
Comment on attachment 8349413 [details] [diff] [review]
Patch

I can review the whole thing.
Attachment #8349413 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8349413 [details] [diff] [review]
Patch

Review of attachment 8349413 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

I assume you've done a case-insensitive grep for "ioncode"... it certainly looks like you did :)

I recommend a |try: -b do -p all -u none -t none| try push on any patch that touches this much code, even though the changes are trivial.
Attachment #8349413 - Flags: review?(n.nethercote) → review+
Assignee

Comment 4

6 years ago
Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c5539b5b8f5

(In reply to Nicholas Nethercote [:njn] from comment #3)
> I recommend a |try: -b do -p all -u none -t none| try push on any patch that
> touches this much code, even though the changes are trivial.

Yup, looks green: https://tbpl.mozilla.org/?tree=Try&rev=58d3a8b0c377
https://hg.mozilla.org/mozilla-central/rev/3c5539b5b8f5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.