Closed Bug 951676 Opened 6 years ago Closed 6 years ago

[Meta][Messages][Refresh] Update layout of list of threads.

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.0, tracking-b2g:backlog)

VERIFIED FIXED
feature-b2g 2.0
tracking-b2g backlog

People

(Reporter: vicky, Unassigned)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken)

Attachments

(1 file, 2 obsolete files)

Update layout to match new proposal for visual refresh.
Specs to follow.
Blocks: SysFE
Whiteboard: ux-tracking, visual design, visual-tracking, bokken
This is marked as MVP#1. 
Do we have more details on this?
blocking-b2g: --- → 1.4?
Flags: needinfo?(firefoxos-ux-bugzilla)
Flags: needinfo?(firefoxos-ux-bugzilla)
Victoria should be providing these soon.
Flags: needinfo?(vpg)
Attaching the visual mockups for messaging inbox, needing info from Pau Masià who will provide the specs file.
Flags: needinfo?(vpg) → needinfo?(b.pmm)
Attached image Visual Mockup: SMS_MMS Inbox (obsolete) —
Attaching the visual specs for Messaging Inbox.
Flags: needinfo?(b.pmm)
Attached image Visual Spec: Messaging Inbox (obsolete) —
Assignee: nobody → joan.leon
Assignee: joan.leon → nobody
Summary: Inbox. Update layout to new design → [Meta][Messages][Refresh] Update layout of list of threads.
blocking-b2g: 1.4? → ---
Thread list view also need the mockup for edit mode.
Flags: needinfo?(vpg)
Blocks: sms-visual-refresh
No longer blocks: SysFE
Comment on attachment 8362504 [details]
Visual Mockup: SMS_MMS Inbox

marking the VD refresh material attached as obsolete since a new reduced scope for v1.4 is going to be proposed within the Messaging meta bug 950175
Attachment #8362504 - Attachment is obsolete: true
Attachment #8362941 - Attachment is obsolete: true
New visual mockups for reduced scope refresh:

https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8370022
Flags: needinfo?(vpg)
Arnau, Joan, I'd like that Oleg has a look here about how to do the contact pictures in a circle in a efficient way, do you already have ideas on how to do this?
Flags: needinfo?(joan.leon)
Flags: needinfo?(arnau)
Could you please check:
https://bugzilla.mozilla.org/show_bug.cgi?id=991006
That's the bug for the refresh in lists BB.
I did a test using border-radius, and performance does not decrease in cold launch time in contacts app with workload light script.
I did not test fps.
It would be great if you could work with this branch, as we would like to land this ASAP :)
Thanks!
Flags: needinfo?(arnau)
Flags: needinfo?(joan.leon)
Arnau, you mean trying to use the branch's work in the Messages app ?

Oleg, maybe you can work on this?
Flags: needinfo?(azasypkin)
(In reply to Julien Wajsberg [:julienw] from comment #12)
> Arnau, you mean trying to use the branch's work in the Messages app ?
> 
> Oleg, maybe you can work on this?

Sure, I'll work on this.
Flags: needinfo?(azasypkin)
The way that is used to make rounded images from the patch for bug 991006 will work for us too once it's landed. 

Arnau, is this patch still in WIP stage? I've noticed that headers inside list and list item bottom borders don't correspond to visual spec: [1], [2].

[1] https://bug950765.bugzilla.mozilla.org/attachment.cgi?id=8394805
[2] https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
Flags: needinfo?(arnau)
Yes, is WIP. I'll check that with Vicky. Thanks for noticing it.

Could we use this bug to add a class for empty images?
As now we have a border for the picture and the image is loaded as a background, empty images are also getting the border.
Flags: needinfo?(arnau)
(In reply to Arnau March  [:arnau] from comment #15)
> Yes, is WIP. I'll check that with Vicky. Thanks for noticing it.
> 
> Could we use this bug to add a class for empty images?
> As now we have a border for the picture and the image is loaded as a
> background, empty images are also getting the border.

I guess we'll have some sort of 'no-image' placeholder instead of empty image like here [1]. In this case I think border would be fine, but I'm not sure whether [1] is the spec that we can trust. Can you point me to the right place where I can look at more or less final design spec for Visual Refresh?
(In reply to Oleg Zasypkin [:azasypkin] from comment #16)
> (In reply to Arnau March  [:arnau] from comment #15)
> Can you point me to the
> right place where I can look at more or less final design spec for Visual
> Refresh?

Oleg, here is the VD for Messages lists:
https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
It would be good to have a "no-image" class to remove the border.
Could you work on that?
I guess this is the only thing we need in this bug.
Flags: needinfo?(azasypkin)
(In reply to Arnau March  [:arnau] from comment #17)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #16)
> > (In reply to Arnau March  [:arnau] from comment #15)
> > Can you point me to the
> > right place where I can look at more or less final design spec for Visual
> > Refresh?
> 
> Oleg, here is the VD for Messages lists:
> https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
> It would be good to have a "no-image" class to remove the border.
> Could you work on that?
> I guess this is the only thing we need in this bug.

Sorry, just noticed that I didn't attach spec reference ([1]) to my previous message. As per [1] I see that we have 4 different states:

1. When we have one recipient (with contact image) associated with the message [1], [2]. We have styles for this in your patch;
2. When we have one recipient (without contact image) associated with the message [2];
3. When we don't have any recipient associated with the message [1] (gray background + question mark);
4. When we have more than one recipient associated with the message [1] (gray background + number of recipients).

Do we have styles for cases #3 and #4 already? 

Sure I can help with no-image styles. I'd like just to confirm as approach for case #2 are somewhat different from #1, #3 and #4: do we really want to left empty space here or it should be similar to what we have for case #3, but with something other than question mark? I mean some placeholder like here near the 'Eric Schmidt' contact name [3]? 

Thanks!

[1] https://mozilla.app.box.com/s/pov1z0nx7whtwrzmd0dz/1/1828237473/16061562207/1
[2] https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
[3] https://developer.android.com/design/media/swipe_views.png
Flags: needinfo?(azasypkin) → needinfo?(arnau)
I guess we should leave that for next week when Vicky is back from PTO :(
I also have some concerns for lists BB.
Flags: needinfo?(arnau)
(In reply to Arnau March  [:arnau] from comment #19)
> I guess we should leave that for next week when Vicky is back from PTO :(
> I also have some concerns for lists BB.

Ok, let's raise it once again next week.

Victoria, can you please share your thoughts on comment 18? Once you're back from PTO :)
Flags: needinfo?(vpg)
I think we can still move forward.

see [1] for the visual mockup, we clearly see that there is an empty space in case 2.

For cases 3 and 4 we can still provide some classes and dataset and then we'll see how we can use them when Victoria provides us the final spec for this.

So let's move forward here :)

[1] https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
(In reply to Oleg Zasypkin [:azasypkin] from comment #18)
> (In reply to Arnau March  [:arnau] from comment #17)
> > (In reply to Oleg Zasypkin [:azasypkin] from comment #16)
> > > (In reply to Arnau March  [:arnau] from comment #15)
> > > Can you point me to the
> > > right place where I can look at more or less final design spec for Visual
> > > Refresh?
> > 
> > Oleg, here is the VD for Messages lists:
> > https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
> > It would be good to have a "no-image" class to remove the border.
> > Could you work on that?
> > I guess this is the only thing we need in this bug.
> 
> Sorry, just noticed that I didn't attach spec reference ([1]) to my previous
> message. As per [1] I see that we have 4 different states:
> 
> 1. When we have one recipient (with contact image) associated with the
> message [1], [2]. We have styles for this in your patch;
> 2. When we have one recipient (without contact image) associated with the
> message [2];
> 3. When we don't have any recipient associated with the message [1] (gray
> background + question mark);
> 4. When we have more than one recipient associated with the message [1]
> (gray background + number of recipients).
> 
> Do we have styles for cases #3 and #4 already? 
> 
> Sure I can help with no-image styles. I'd like just to confirm as approach
> for case #2 are somewhat different from #1, #3 and #4: do we really want to
> left empty space here or it should be similar to what we have for case #3,
> but with something other than question mark? I mean some placeholder like
> here near the 'Eric Schmidt' contact name [3]? 
> 
> Thanks!
> 
> [1]
> https://mozilla.app.box.com/s/pov1z0nx7whtwrzmd0dz/1/1828237473/16061562207/1
> [2] https://bug950175.bugzilla.mozilla.org/attachment.cgi?id=8394790
> [3] https://developer.android.com/design/media/swipe_views.png

Oleg, this grey images were placeholders ment to be replaced by a custom designed image made by our new illustrator in the team, Sabrina. But I haven't seen any progress in that area, so NI to Stephany as she should know the state of this. If not, please, do not use any generic image and leave the space empty as we have been doing so far. THanks!
Flags: needinfo?(vpg) → needinfo?(swilkes)
Flags: needinfo?(padamczyk)
Oleg please refer to comment 22. We do have new generic images on the way however they will likely be for v.2.1+
Flags: needinfo?(padamczyk)
Patryk has responded with the information requested of me.
Flags: needinfo?(swilkes)
QA Contact: lolimartinezcr
All dependencies bug are fixed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1003789
No longer depends on: 1003789
Attached image 2014-04-30-master.png
Hi,

It is not clear to me how it should look like in 2.0 (mainly) in case of #3 (no recipient), #4 (more than one recipient) scenarios.
Please see the screenshot attached showing the current behavior in today's (4/30) master build:
Device: Hamachi
Gecko: 13b2542
Gaia: 08ea844
BuildId: 20140430075058
Platform version: 32.0a1

1. When we have one recipient (with contact image) associated with the message -> The contact image is shown (OK)
2. When we have one recipient (without contact image) associated with the message -> no image is shown (OK)
3. When we don't have any recipient associated with the message -> no image is shown (OK?)
4. When we have more than one recipient associated with the message -> the image associated to one of the contacts is shown (KO?)

ni to visual design team to clarify 2.0 scenario and open follow up bugs if needed. Thanks!
Flags: needinfo?(vpg)
(In reply to Noemí Freire (:noemi) from comment #26)

> 3. When we don't have any recipient associated with the message -> no image
> is shown (OK?)
OK
> 4. When we have more than one recipient associated with the message -> the
> image associated to one of the contacts is shown (KO?)

A circle with the number of recipients of that message will be shown. Will provide specs for this next week.
Thanks.
Depends on: 1003843
(In reply to Victoria Gerchinhoren [:vicky] from comment #27)
> (In reply to Noemí Freire (:noemi) from comment #26)
> > 4. When we have more than one recipient associated with the message -> the
> > image associated to one of the contacts is shown (KO?)
> 
> A circle with the number of recipients of that message will be shown. Will
> provide specs for this next week.
> Thanks.

A follow up has been created to track scenario #4, please refer to Bug 1003843.
Flags: needinfo?(vpg)
Flags: in-moztrap?(nhirata.bugzilla)
Tested and working
1.5
Hamachi
Gecko: d6d67dao
Gaia: 9078b76
Status: RESOLVED → VERIFIED
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.