Single variant build process uses invalid init.json

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: albert, Assigned: albert)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: burirun1.3-1 [systemsfe])

Attachments

(1 attachment)

363 bytes, text/html
yurenju
: review+
Details
(Assignee)

Description

4 years ago
Since bug 929602 landed, some dependencies of gaia Makefile has changed and currently single variant script is run before init.json is generated.
(Assignee)

Updated

4 years ago
Assignee: nobody → acperez

Updated

4 years ago
Whiteboard: burirun1.3-1

Comment 1

4 years ago
Marking this as urgent as it blocks SIM customization testing - we have a testrun going right now.
blocking-b2g: --- → 1.3?
(Assignee)

Comment 2

4 years ago
John, we don't need the flag for 1.3 here, as I commented in bug 951450, this bug only affects master (1.4)

Updated

4 years ago
Component: General → Gaia
Product: Firefox → Firefox OS
Whiteboard: burirun1.3-1 → burirun1.3-1 [systemsfe]
(In reply to Albert [:albert] from comment #2)
> John, we don't need the flag for 1.3 here, as I commented in bug 951450,
> this bug only affects master (1.4)

Removing nom as such then - feel free to nom for 1.4 if you think that has blocking impact for 1.4.
blocking-b2g: 1.3? → ---
(Assignee)

Updated

4 years ago
blocking-b2g: --- → 1.4?
(Assignee)

Comment 4

4 years ago
The bug can be reproduced in fresh gaia clone or deleting apps/homescreen/js/init.json
(Assignee)

Comment 5

4 years ago
Created attachment 8364308 [details]
Patch
Attachment #8364308 - Flags: review?(yurenju.mozilla)
Comment on attachment 8364308 [details]
Patch

r=yurenju, thanks.
Attachment #8364308 - Flags: review?(yurenju.mozilla) → review+
(Assignee)

Comment 7

4 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/a79db5f1c8be7a4be2d2b3d6bd1db144eb4e4ae5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
blocking-b2g: 1.4? → ---
You need to log in before you can comment on or make changes to this bug.