951713 - CacheIOThread causes activity spikes during idle

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Roberto Agostino Vitillo (:rvitillo)]

The event loop of CacheIOThread is executed every five seconds during idle (http://dxr.mozilla.org/mozilla-central/source/netwerk/cache2/CacheIOThread.cpp#125).

Comment 1

[Honza Bambas (:mayhemer)]

I think this is just a debugging tool for me.  There is no reason to tick at all.

Comment 2

[Roberto Agostino Vitillo (:rvitillo)]

Great, do you want me to submit a patch or are you going to take care of it?

Comment 3

[Honza Bambas (:mayhemer)]

I'll do it.

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 5

[Michal Novotny [:michal]]

Comment on attachment 8349611 [details] [diff] [review]
v1

Review of attachment 8349611 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache2/CacheIOThread.cpp
@@ +167,5 @@
>  
>        if (EventsPending())
>          goto loopStart;
>  
> +    } while (true);

With this change, all gotos can be replaced by continue except the one in the for loop. Could you please rewrite the loop so that we can get rid of the goto statements?

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: v2

Here it is.  Thanks for the quick rev!

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 8349769 [details] [diff] [review]
v2

https://hg.mozilla.org/integration/mozilla-inbound/rev/86eb809847a3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86eb809847a3