Closed Bug 951748 Opened 6 years ago Closed 3 years ago

Consistently use ‘Draft message’ instead of ‘Message draft’

Categories

(MailNews Core :: Account Manager, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 49.0

People

(Reporter: Tonnes, Assigned: Tonnes)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch cc_rev13404_draft_messages.patch (obsolete) — Splinter Review
After bug 562048 (TB) and bug 633937 (SM) were fixed recently, an occurrence of ‘Draft message’ passed by. There’s nothing wrong with that (on the contrary), but in the Copies & Folders section and some SM Help files, ‘Message draft’ has been used so far. This of course isn’t consistent and may confuse end users and even localizers.

http://mxr.mozilla.org/comm-central/search?string=message%2Bdraft
http://mxr.mozilla.org/comm-central/search?string=draft%2Bmessage

As ‘Draft message’ seems to be used more often by other parties and apparently is the better word when doing some searches, it would be nice to use ‘Draft message’ only. This patch changes the occurrences for both TB and SM including its Help files (where it also fixes an index typo), but leaves code like ‘messageDrafts’ as it is.
In Copies&Folders the name "message drafts" is probably used to align with the other labels having "message archives" and "message templates". Wouldn't changing only "message drafts" appear out of place there now?
Agree, "Message draft" might have been used for a cosmetic reason (only). I wonder if that is valid one though - it wouldn't stop me from using proper terms.
Severity: normal → minor
Whiteboard: [patchlove]
Maybe this does not need patch love, maybe Ton is still around, the patch just never asked for review.
Ton, can you refresh the patch for current trunk, if needed?
Version: unspecified → Trunk
New patch for current trunk as requested. No new or disappeared occurrences, help links tested.
Attachment #8349513 - Attachment is obsolete: true
Attachment #8751234 - Flags: review?(richard.marti)
Attachment #8751234 - Flags: review?(philip.chee)
Assignee: nobody → tonnes.mb
Status: NEW → ASSIGNED
Whiteboard: [patchlove]
Comment on attachment 8751234 [details] [diff] [review]
Draft_message_v2.patch

r+ for the TB part.
Attachment #8751234 - Flags: review?(richard.marti) → review+
Comment on attachment 8751234 [details] [diff] [review]
Draft_message_v2.patch

Looks reasonable r=me
Attachment #8751234 - Flags: review?(philip.chee) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/a38deb7c45f5cc801aab3139706631dedf91b8fb
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
You need to log in before you can comment on or make changes to this bug.