Consistently use ‘Draft message’ instead of ‘Message draft’

RESOLVED FIXED in Thunderbird 49.0

Status

--
minor
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: Tonnes, Assigned: Tonnes)

Tracking

Trunk
Thunderbird 49.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 8349513 [details] [diff] [review]
cc_rev13404_draft_messages.patch

After bug 562048 (TB) and bug 633937 (SM) were fixed recently, an occurrence of ‘Draft message’ passed by. There’s nothing wrong with that (on the contrary), but in the Copies & Folders section and some SM Help files, ‘Message draft’ has been used so far. This of course isn’t consistent and may confuse end users and even localizers.

http://mxr.mozilla.org/comm-central/search?string=message%2Bdraft
http://mxr.mozilla.org/comm-central/search?string=draft%2Bmessage

As ‘Draft message’ seems to be used more often by other parties and apparently is the better word when doing some searches, it would be nice to use ‘Draft message’ only. This patch changes the occurrences for both TB and SM including its Help files (where it also fixes an index typo), but leaves code like ‘messageDrafts’ as it is.

Comment 1

5 years ago
In Copies&Folders the name "message drafts" is probably used to align with the other labels having "message archives" and "message templates". Wouldn't changing only "message drafts" appear out of place there now?
(Assignee)

Comment 2

5 years ago
Agree, "Message draft" might have been used for a cosmetic reason (only). I wonder if that is valid one though - it wouldn't stop me from using proper terms.

Updated

3 years ago
Severity: normal → minor
Whiteboard: [patchlove]

Comment 3

3 years ago
Maybe this does not need patch love, maybe Ton is still around, the patch just never asked for review.
Ton, can you refresh the patch for current trunk, if needed?
Version: unspecified → Trunk
(Assignee)

Comment 4

3 years ago
Created attachment 8751234 [details] [diff] [review]
Draft_message_v2.patch

New patch for current trunk as requested. No new or disappeared occurrences, help links tested.

Updated

3 years ago
Attachment #8349513 - Attachment is obsolete: true

Updated

3 years ago
Attachment #8751234 - Flags: review?(richard.marti)
Attachment #8751234 - Flags: review?(philip.chee)

Updated

3 years ago
Assignee: nobody → tonnes.mb
Status: NEW → ASSIGNED
Whiteboard: [patchlove]
Comment on attachment 8751234 [details] [diff] [review]
Draft_message_v2.patch

r+ for the TB part.
Attachment #8751234 - Flags: review?(richard.marti) → review+

Comment 6

3 years ago
Comment on attachment 8751234 [details] [diff] [review]
Draft_message_v2.patch

Looks reasonable r=me
Attachment #8751234 - Flags: review?(philip.chee) → review+

Updated

3 years ago
Keywords: checkin-needed

Comment 7

3 years ago
https://hg.mozilla.org/comm-central/rev/a38deb7c45f5cc801aab3139706631dedf91b8fb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
You need to log in before you can comment on or make changes to this bug.