Closed Bug 951802 Opened 6 years ago Closed 6 years ago

Add a localization comment to crash reporter prompt explaining that privacy policy link must go after the sentence describing it

Categories

(Firefox for Metro Graveyard :: General, enhancement, P2)

x86
Windows 8.1
enhancement

Tracking

(firefox27 unaffected, firefox28 fixed, firefox29 unaffected)

RESOLVED FIXED
Firefox 28
Tracking Status
firefox27 --- unaffected
firefox28 --- fixed
firefox29 --- unaffected

People

(Reporter: aryx, Assigned: ally)

References

Details

(Keywords: l12y, Whiteboard: [beta28] [defect] p=1 [qa-])

Attachments

(1 file)

At the moment, the crashreporter has the following text:

<!ENTITY crashprompt.detailedMessage.thirdParagraph "We use crash reports to try to fix problems and improve our products. We handle your information as we describe in our ">
<!ENTITY crashprompt.privacyPolicyLink "&brandShortName; privacy policy">

This means the privacy policy has always to be at the end of the sentence which is problematic for localization.
Whiteboard: [triage]
Oops.  :(

We can fix this on mozilla-central, but what should be do about the strings that are already on Aurora?  Should we rely on localizers to come up with creative phrasing to make this work in each locale; break string freeze by adding a third (empty) string for text after the link; or apply a technical fix?

(For example, as a technical fix we could make the whole paragraph into a link.  This isn't our ideal UX, but it would work in all locales and would not break string freeze.)
Blocks: 903426
Flags: needinfo?(community)
community@localization.bugs is an alias, CC should be enough.

Ideally string concatenation should be avoided (use a variable in the main string that localizers can move around, replace the variable with link+text from the other entity at run-time). The alternative is to use at least 3 strings (before-link, link, after-link).

What scares me about breaking string freeze on Aurora is that the change is probably not going to land before the second week of January.

From a localizer point of view there are ways to work around this issue, like translating the string as: "We use crash reports to try to fix problems and improve our products. We handle your information as we describe in our &brandShortName; privacy policy." + "<a>Learn more.</a>"

But I don't expect a lot of locales to come up with this solution.

My first suggestion would be to add a localization comment on Aurora explaining the problem and suggesting the above solution as a temporary fix, then fix the string for real on mozilla-central.

Pike, thoughts on this?
Flags: needinfo?(community) → needinfo?(l10n)
Agreed.
Flags: needinfo?(l10n)
Whiteboard: [triage] → [beta28] [defect] p=0
Morphing this bug into - "My first suggestion would be to add a localization comment on Aurora explaining the problem."

We'll file a follow up on fixing this on mc.
Filed bug 957167 for "fix the string for real on mozilla-central"

Morphing this bug into "add localization comment explaining the problem"
Summary: crash reporter: Allow positioning privacy policy link at arbitrary position in sentence → Add a localization comment to crash reporter prompt explaining that privacy policy link must go after the sentence describing it
QA Contact: ally
ok, so land this on aurora only, since bug 957167 has been resolved?
(In reply to :Ally Naaktgeboren from comment #6)
> ok, so land this on aurora only, since bug 957167 has been resolved?

Yes, please.
Assignee: nobody → ally
QA Contact: ally
Whiteboard: [beta28] [defect] p=0 → [beta28] [defect] p=1
Blocks: metrov1it23
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
since you gotta land it, you might as well review it. ;)
Attachment #8363863 - Flags: review?(mbrubeck)
Is this the patch landing on mozilla-aurora only? Then I suggest adding something more explicit.

Example:

These two entities are concatenated to create a single sentence: crashprompt.privacyPolicyLink is a clickable link following crashprompt.detailedMessage.thirdParagraph. In case this structure doesn't work for your locale, you can move "&brandShortName; privacy policy." to the first sentence, and use a generic "More information" for the link. This sentence will be updated in the next versions of Firefox.
Comment on attachment 8363863 [details] [diff] [review]
localization comment, for Aurora landing only (no m-c)

I landed ally's patch plus some of flod's suggested text from comment 9.  Thank you, both of you:
https://hg.mozilla.org/releases/mozilla-aurora/rev/b8fb14d0d1a3
Attachment #8363863 - Flags: review?(mbrubeck) → review+
Keywords: l12y
Target Milestone: --- → Firefox 28
Thanks for handling the aurora landings mbrubeck!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [beta28] [defect] p=1 → [beta28] [defect] p=1 [qa-]
You need to log in before you can comment on or make changes to this bug.