Closed
Bug 951816
Opened 11 years ago
Closed 11 years ago
Improve error reporting of PR_Connect failure in strsclnt
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.15.4
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
1.51 KB,
patch
|
briansmith
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
The attached patch improves error reporting of PR_Connect failure in strsclnt. 1. I changed errWarn to print the OS error and not insert a newline before the error string. Right now it prints this: strsclnt: PR_Connect returned error -5982: Local Network address is in use With the patch, it will print this: strsclnt: PR_Connect returned error -5982, OS error 98: Local Network address is in use 2. I save and restore the error codes if we call other functions after PR_Connect fails.
Attachment #8349603 -
Flags: review?(brian)
|
||
Updated•11 years ago
|
Attachment #8349603 -
Flags: review?(brian) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
Comment on attachment 8349603 [details] [diff] [review] Patch Review of attachment 8349603 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/projects/nss/rev/2c499c260b55
Attachment #8349603 -
Flags: checked-in+
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.15.4
You need to log in
before you can comment on or make changes to this bug.
Description
•