951829 - [Contacts API] new mozContact().id returns the string "undefined"

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Contacts, defect)

Description

[Julien Wajsberg [:julienw]]

As discussed in bug 931711, it should probably be null or "" instead.

null:
* make it clear we have no id
* needs a WebIDL change

"":
* the id is defined but is falsy
* doesn't need a WebIDL change

What are other API doing?

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: wip patch v1

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Try is https://tbpl.mozilla.org/?tree=Try&rev=7372e6313cc0

I'd like to see what Gaia integration tests react on this.

Comment 3

[Julien Wajsberg [:julienw]]

> 
> I'd like to see what Gaia integration tests react on this.

*how

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't think there's much consistency between APIs. My experience is that using "" creates fewer edge cases for authors while making most code patterns JustWork.

So "" gets my vote.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] julienw:951829-recognize-falsy-id > mozilla-b2g:master

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8706418 [details] [review]
[gaia] julienw:951829-recognize-falsy-id > mozilla-b2g:master

Hey Francisco, what do you think ? This is a small fix to prevent issues when I'll try to land the gecko patch.

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: 0001-Bug-951829-new-mozContact-.id-should-be-the-empty-st.patch

Waiting to get my ssh account back to push to try.

Comment 8

[Julien Wajsberg [:julienw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=915f5734f73e

Comment 9

[Julien Wajsberg [:julienw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2fe9d3c02c2

Comment 10

[Julien Wajsberg [:julienw]]

Gij seems happy, which is sad because after all the Gaia patch is not landed yet... this means this part is not tested :/

Comment 11

[Julien Wajsberg [:julienw]]

Attachment: [PATCH] - new mozContact().id should be the empty string

From dbdf6ce56401e4b2e64dce53d96cdd0d97f9198d Mon Sep 17 00:00:00 2001
 r=reuben
---
 dom/contacts/ContactManager.js                | 6 ++++--
 dom/contacts/tests/test_contacts_basics2.html | 6 ++++++
 dom/webidl/Contacts.webidl                    | 2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8706418 [details] [review]
[gaia] julienw:951829-recognize-falsy-id > mozilla-b2g:master

LGTM :)

Comment 13

[Sylvestre Ledru [:Sylvestre]]

DOM: Contacts isn't used anymore. 
Closing all remaining bugs.