Closed Bug 951875 Opened 7 years ago Closed 7 years ago

Respect binaryNames in JS-implemented interfaces

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: reuben, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

Actually apply binarynames to JS-implemented codegen.
9.06 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
Patch for aurora
8.94 KB, patch
Details | Diff | Splinter Review 
Right now if I try to map 'init' to 'init_old' in the mozContact interface I get this error:

ContactsBinding.cpp:12319:17: error: no member named 'Init_old' in 'mozilla::dom::mozContactJSImpl'
Actually, this applies them to all callbacks, but most callback interfaces don't have entries in Bindings.conf.

This removes the extra entry for TestJSImplInterface in Bindings.conf that was covering up this bug.
Attachment #8349712 - Flags: review?(continuation)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Whiteboard: [need review]
Attachment #8349712 - Flags: review?(continuation) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a92812ca30c
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/3a92812ca30c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 951766
Blocks a blocker.
blocking-b2g: --- → 1.3?
Attached patch Patch for aurora — — Splinter Review
blocking-b2g: 1.3? → 1.3+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.