951876 - make test-agent-test fails

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Hubert Figuiere [:hub]]

$ make test-agent-test
Running all tests
/bin/bash: tools/test-agent//node_modules/test-agent/bin/js-test-agent: No such file or directory
make: *** [test-agent-test] Error 127

I don't have any "node_modules" anywhere in the tree (I nuked those installed by make test-perf for test sake).

Expected:

1. no error
2. an error telling me what I'm missing. But really, see 1.

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Aug 24)]

everything should be installed when you run "make test-agent-server", which you need to run before anyway, otherwise make test-agent-test won't work.

We could probably add a dependency to "common-install" for test-agent-test, but really this wouldn't help much.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Dependency of "node_modules" has been added to "make test-agent-test" now, but we couldn't just run "make test-agent-test" to launch test without "make test-agent-server".

As MDN said (https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_unit_tests), we could run "bin/gaia-test" to launch Firefox and test-agent-server then run "make test-agent-test" for launching tests. So I think it is sufficiently clear to guide how to run Gaia unit test. :)

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 24)]

yep, let's close this!