At the beginning of the 1.3 cycle I added the ability to select a ringtone from the Music app via a pick activity. In 1.3, when you use the settings app to change your ringtone, you always have to choose between "System Ringtones" and "Music". This turns out to be a misfeature. We already have the ability to share a song as a ringtone, and the pick from music feature will be removed in 1.4. We should also remove it from 1.3 so it is not an orphan feature that exists (and forces and extra click) in just one release. This will be a one-line patch, but I'm going to nominate it as a blocker because we really want to get ringtones right in 1.4 and don't want a backward compatibility headache for 1.3.
Nominating for 1.3. Needinfo for Hema so it is on her radar and so she can talk about this during triage. And cc Jacqueline since she is the ringtone UX lead.
Assignee: nobody → dflanagan
blocking-b2g: --- → 1.3?
This did not show up in my triage query, because it was in the Settings component. However, based on the discussions that we had today for Ringtone in 1.4, it makes sense to remove it from 1.3. I don't want to mark this a 1.3+ because it is not a blocker per se. We can approve the patch for 1.3 since it is a low risk one line change provided Fabrice also agrees (he is the 1.3 sheriff) NI'd Sri to ensure we dont have objections from product side to remove it.
Triage: please ask for approval for the patch.
blocking-b2g: 1.3? → -
I don't have any objection sto take that on 1.3
Created attachment 8350783 [details] [review] one-line patch
Attachment #8350783 - Flags: review?(dmarcos)
This patch Fabrice's approval to land in 1.3. I have offline UX review from Jacqueline.
The patch looks good to me.
Attachment #8350783 - Flags: review?(dmarcos) → review+
Uplifted to v1.3 with approval above from Fabrice: https://github.com/mozilla-b2g/gaia/commit/5218575ec22e6b69c4bc75ee297ff1fb07fd2cb2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g-v1.2: --- → unaffected
status-b2g-v1.3: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.