Closed
Bug 951950
Opened 11 years ago
Closed 10 years ago
Fix tests for Fennec
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
Causing tests to fail on Fennec
|
Assignee | |
Updated•11 years ago
|
OS: Mac OS X → Android
|
|
Assignee | |
Updated•11 years ago
|
Summary: Remove platform-dependent window tests out of test-window-common → Fix tests for Fennec
Priority: -- → P1
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8358668 -
Flags: review?(evold)
|
||
Comment 3•10 years ago
|
||
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #2) > Why doesn't getView work on Fennec? I mean viewFor, but I see that it was not implemented https://github.com/mozilla/addon-sdk/commit/c9e4a7a2b83fb40c47f8e40ba45f7bc6c966a8f6
|
|
||
Updated•10 years ago
|
Attachment #8358668 -
Flags: review?(evold) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Yeah, wasn't implemented -- we can add it in the future, but I just want tests passing for now the very least!
Flags: needinfo?(jsantell)
|
||
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/c5699b7b8b6728cf7eb01bb4a947cbabd11f7b24 Bug 951950 Fix tests that don't run on Fennec, fix event/core iterating over invalid properties (localStorage) for Fennec's tab which accepts a window https://github.com/mozilla/addon-sdk/commit/d683fba4d8d44cd0989b8ead2e8613707294e75a Merge pull request #1340 from jsantell/fix-fennec-tests Fix Bug 951950 Fix tests that don't run on Fennec, r=@erikvodl
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•