951975 - devtools/sourceeditor/editor should let me reconfigure CodeMirror to change line wrapping

Status: VERIFIED FIXED

(DevTools :: Source Editor, defect, P3)

Description

[Jason Barnabe (np)]

I'm attempting to implement CodeMirror in my extension Stylish. I would like to allow users to choose whether to wrap lines and have that choice reflected immediately.

CodeMirror has a setOption method[1] that lets you change its configuration on the fly, including lineWrapping[2]. The JS implemented in devtools/sourceeditor/editor[3] hides the "cm" object from me so I can't access it to call this method. Oddly, it only lets me change the "mode" of CodeMirror[4].

I would like to have a setLineWrapping method, or more generally, a setOption method to be able to reconfigure CodeMirror on the fly.

1: http://codemirror.net/doc/manual.html#setOption
2: http://codemirror.net/doc/manual.html#option_lineWrapping
3: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/sourceeditor/editor.js
4: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/sourceeditor/editor.js#291

Comment 1

[Anton Kovalyov (:anton)]

Since we already allow people to pass CodeMirror configuration I don't mind exposing setOption method *but* it has to reflect all the custom stuff we do in the constructor. In fact, constructor should probably use setOption.

Comment 2

[Anton Kovalyov (:anton)]

Attachment: WIP 1

Actually, when I started doing this I realized that we don't do anything custom to CodeMirror options so this patch came to be super simple.

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 8356298 [details] [diff] [review]
WIP 1

Nice.

Comment 4

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/ce93390b4fce

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce93390b4fce

Comment 6

[Jason Barnabe (np)]

Thanks, this works. I've released Stylish 1.4.1b1 with support for this.

http://forum.userstyles.org/discussion/39738/stylish-for-firefox-1-4-1b1
https://github.com/JasonBarnabe/stylish/issues/167