951979 - Assertion failure: compilationLockOwner != PR_GetCurrentThread(), at vm/Runtime.cpp:997

Status: VERIFIED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Stack from Crash Reporter

Assertion failure: compilationLockOwner != PR_GetCurrentThread(), at vm/Runtime.cpp is an assertion that has hard-to-reproduce testcases, and which appeared fairly recently (probably in the past weeks?).

Not sure where this lives, setting needinfo? from jandem in case he has any ideas. :)

Comment 1

[Jan de Mooij [:jandem]]

Brian, do you have any idea what's going on?

Comment 2

[Jan de Mooij [:jandem]]

I think the problem is GlobalObject::addIntrinsicValue taking the compilation lock, and then we try to take the operationCallbackLock as well.

Comment 3

[Brian Hackett [Laid off!]]

Attachment: patch

I don't think there is any place we take the compilation lock while holding the operation callback lock, so we can just fixup the lock ordering constraints.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8350311 [details] [diff] [review]
patch

Review of attachment 8350311 [details] [diff] [review]:
-----------------------------------------------------------------

Glad it's this simple.

Comment 5

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6296ca67d80b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6296ca67d80b

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I haven't seen this since.